Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upShow THE SQUIRREL #8
Conversation
|
I think it'd be good to add a spec for this little dude, similar to the one from release notes. |
|
Yeah definitely |
|
This is ready for |
|
|
||
| dispatchCall = spyOn(atom.commands, 'dispatch') | ||
| $(workspaceElement).find('.about-release-notes').trigger('click') | ||
| expect(dispatchCall.mostRecentCall.args[1]).toBe 'about:view-release-notes' |
maxbrunsfeld
Jan 12, 2016
Contributor
Since the handling of the about:view-release-notes command is not described elsewhere in the spec, It might be nice to include that's command behavior in this test by spying on shell.openExternal instead of atom.commands.dispatch.
Since the handling of the about:view-release-notes command is not described elsewhere in the spec, It might be nice to include that's command behavior in this test by spying on shell.openExternal instead of atom.commands.dispatch.
joshaber
Jan 12, 2016
Author
Contributor
Yeah I was on the fence about that. It felt a bit like testing an implementation detail, but I can test it if you prefer 👍
Yeah I was on the fence about that. It felt a bit like testing an implementation detail, but I can test it if you prefer
maxbrunsfeld
Jan 12, 2016
Contributor
Yeah, a pretty minor distinction, I agree. My thought was that they're both implementation details, but the behavior of openExternal is at least defined outside of this package.
Yeah, a pretty minor distinction, I agree. My thought was that they're both implementation details, but the behavior of openExternal is at least defined outside of this package.
| atom.commands.dispatch(atom.views.getView(atom.workspace), 'about:view-release-notes') | ||
| }) | ||
|
|
||
| this.subscriptions.add(atom.tooltips.add(this.element, {title: 'An update will be installed the next time Atom is relaunched.<br/><br/>Click to view release notes.'})) |
lee-dohm
Jan 13, 2016
Member
👍
|
Alright, I think this is really and truly ready |
|
Let's do this! |
|
Thanks for fixing this long-standing pain-point. |
|
|
| this.subscriptions = new CompositeDisposable() | ||
|
|
||
| this.on('click', () => { | ||
| atom.commands.dispatch(atom.views.getView(atom.workspace), 'about:view-release-notes') |
benogle
Jan 13, 2016
Contributor
Should this show the about page then have a button on the about page that triggers the restart? This flow seems maybe not ideal to have the squirrel point to the external page. I would like to train users that the version / update info is on the about page.
Should this show the about page then have a button on the about page that triggers the restart? This flow seems maybe not ideal to have the squirrel point to the external page. I would like to train users that the version / update info is on the about page.
joshaber
Jan 13, 2016
Author
Contributor
We could, though as a user I'm not sure what going to the About view gives me, besides another click to view Release Notes.
We could, though as a user I'm not sure what going to the About view gives me, besides another click to view Release Notes.
benogle
Jan 13, 2016
Contributor
It gives info about the version you're on, what is available and a button to restart, along with a release notes button. Similar to chrome.
It gives info about the version you're on, what is available and a button to restart, along with a release notes button. Similar to chrome.
benogle
Jan 13, 2016
Contributor
The goal is to have the about page be the sort of hub for version and update management stuff e.g. atom/atom#9164. Like when folks uncheck the new autoupdate option, we should provide a way to check for an update on the about page.
The goal is to have the about page be the sort of hub for version and update management stuff e.g. atom/atom#9164. Like when folks uncheck the new autoupdate option, we should provide a way to check for an update on the about page.
joshaber
Jan 13, 2016
Author
Contributor
Ah yeah, but it doesn't do any of that stuff currently. This is just a stop gap so we can stop getting a billion issue reports about release notes being wrong. But if you feel strongly I can change this to open About.
Ah yeah, but it doesn't do any of that stuff currently. This is just a stop gap so we can stop getting a billion issue reports about release notes being wrong. But if you feel strongly I can change this to open About.
benogle
Jan 13, 2016
Contributor
It's ok for this release. With the removal of the release notes package, we are removing the 'restart and update' button. So people will need to manually quit and restart atom to get the update to take effect. I know we're close to releasing, so might be too much to ask to get that button added at this point. But it's something we should add back for the next release.
It's ok for this release. With the removal of the release notes package, we are removing the 'restart and update' button. So people will need to manually quit and restart atom to get the update to take effect. I know we're close to releasing, so might be too much to ask to get that button added at this point. But it's something we should add back for the next release.
joshaber
Jan 13, 2016
Author
Contributor
Should we slow it down and not bring these changes into 1.4?
Should we slow it down and not bring these changes into 1.4?
benogle
Jan 13, 2016
Contributor
I think we should continue with it. The upside is that we wont get any release notes issues. The issues might come in when we release 1.5 as folks might be confused that there is no restart button. Or maybe no one will care, and my worries are unfounded. In any case, I think this is better than what we had.
I think we should continue with it. The upside is that we wont get any release notes issues. The issues might come in when we release 1.5 as folks might be confused that there is no restart button. Or maybe no one will care, and my worries are unfounded. In any case, I think this is better than what we had.
joshaber
Jan 13, 2016
Author
Contributor
👍
Add the squirrel icon when an update is available.
See atom/atom#10377 for the discussion that prompted this.
/cc @atom/feedback