Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Disable whitelist with DISABLE_WHITELIST flag #258
Merged
Conversation
| let(:configuration) { Jekyll.configuration(test_config) } | ||
| let(:site) { Jekyll::Site.new(configuration) } | ||
| let(:effective_config) { described_class.effective_config(site.config) } | ||
| before { ENV.delete("DISABLE_WHITELIST") } | ||
| before { ENV["JEKYLL_ENV"] = "test" } |
parkr
Mar 19, 2016
Member
before is generally seen as bad to use, because it's not specific. before(:all) or before(:each) would be preferable.
before is generally seen as bad to use, because it's not specific. before(:all) or before(:each) would be preferable.
lib/github-pages/configuration.rb
Outdated
| @@ -83,6 +83,10 @@ def processed(site) | |||
| site.instance_variable_set :@_github_pages_processed, true | |||
| end | |||
|
|
|||
| def disable_whitelist? | |||
| Jekyll.env == "development" && ENV["DISABLE_WHITELIST"] == "1" | |||
parkr
Mar 19, 2016
Member
What if I write DISABLE_WHITELIST=true? That'd fail here. Could we be more flexible on its value?
What if I write DISABLE_WHITELIST=true? That'd fail here. Could we be more flexible on its value?
Gemfile
Outdated
|
|
||
| gem "jekyll_test_plugin_malicious", | ||
| :github => "jekyll/jekyll-test-plugin-malicious", | ||
| :branch => "safe-flag" |
|
@benbalter still working on this? |
|
@parkr pushed up updates for your comments |
Gemfile
Outdated
| @@ -1,3 +1,5 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| gemspec | |||
|
|
|||
| gem "jekyll_test_plugin_malicious", :github => "jekyll/jekyll-test-plugin-malicious" | |||
parkr
Mar 24, 2016
Member
Can this be removed?
Can this be removed?
benbalter
Mar 24, 2016
Author
Contributor
It doesn't appear to be in Ruby gems?
It doesn't appear to be in Ruby gems?
benbalter
Mar 25, 2016
Author
Contributor
Had 2.0, not 0.2. Fixed.
Had 2.0, not 0.2. Fixed.
spec/fixtures/_config.yml
Outdated
| quiet: false | ||
| repository: "github/pages-gem" |
parkr
Mar 24, 2016
Member
Didn't we have a PR that grabbed this from the git remote-url?
Didn't we have a PR that grabbed this from the git remote-url?
… into disable-whitelist
|
@parkr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This will allow users to run non-whitelisted plugins locally, by passing the
DISABLE_WHITELISTflag, which will whitelist any plugins included in the gem list.