33

How can I generate random Int64 and UInt64 values using the Random class in C#?

11 Answers 11

75

This should do the trick. (It's an extension method so that you can call it just as you call the normal Next or NextDouble methods on a Random object).

public static Int64 NextInt64(this Random rnd)
{
    var buffer = new byte[sizeof(Int64)];
    rnd.NextBytes(buffer);
    return BitConverter.ToInt64(buffer, 0);
}

Just replace Int64 with UInt64 everywhere if you want unsigned integers instead and all should work fine.

Note: Since no context was provided regarding security or the desired randomness of the generated numbers (in fact the OP specifically mentioned the Random class), my example simply deals with the Random class, which is the preferred solution when randomness (often quantified as information entropy) is not an issue. As a matter of interest, see the other answers that mention RNGCryptoServiceProvider (the RNG provided in the System.Security namespace), which can be used almost identically.

Sign up to request clarification or add additional context in comments.

6 Comments

+1 for giving the OP what they asked for as well as mentioning the limitations of using Random and offering an alternative if the limitations of Random are too restrictive for the intended use.
Note that this approach also returns negative numbers and Int64.MaxValue, while System.Random.Next() is constrained to positive numbers including 0 but without Int32.MaxValue.
@Christoph: Yeah, well observed. You could however modify my method quite easily to only produce positive values by ignoring the MSB (most significant bit) of the buffer.
I tried implementing this solution but found that the results weren't satisfactorily random. After generating thousands of numbers, I found that the vast majority of the numbers had 19 digits, the occasional number had 18 digits, and the very rare number had 17 digits. Out of the thousands of numbers I generated, I never saw any number with 16 digits or less. How could this solution be modified to fix this?
@kd7iwp: I fear you have a slightly befuddled perception of "random" here. The key here is the distribution of the generated values. Are the integers distributed uniformly? Yes, of course, since their bits are independent and uniform random variables. Now observe that there are ~10 times as many numbers with (n + 1) digits as there are with n digits, and it should be clear enough to you.
|
29

Use Random.NextBytes() and BitConverter.ToInt64 / BitConverter.ToUInt64.

// Assume rng refers to an instance of System.Random
byte[] bytes = new byte[8];
rng.NextBytes(bytes);
long int64 = BitConverter.ToInt64(bytes, 0);
ulong uint64 = BitConverter.ToUInt64(bytes, 0);

Note that using Random.Next() twice, shifting one value and then ORing/adding doesn't work. Random.Next() only produces non-negative integers, i.e. it generates 31 bits, not 32, so the result of two calls only produces 62 random bits instead of the 64 bits required to cover the complete range of Int64/UInt64. (Guffa's answer shows how to do it with three calls to Random.Next() though.)

13 Comments

Oh, good catch (comment) - I'm deleting mine, as the BitConverter etc is already well covered...
Okay - I put that in my answer rather than just a comment so that it would be more visible. I'm going to leave it in now anyway as a warning for the future (as otherwise it's an obvious alternative).
Due to the fact that majority of lcm PRNG are less random in the low order bits, generating 2 numbers and joining them together may introduce subtle biases...
@JonSkeet Random values are distributed uniformly. I'm not sure that we'll get uniformly disrtibuted value with following method, especially if we are dropping MSB. And we also can get a value from 2 randoms, if the second call will be random.Next(int.MinValue, int.MaxValue) so all bytes will be filled.
@AlexZhukovskiy: That's changing your objection entirely, and is based on an implementation detail. You can do it with 3 calls to Random.Next even if you want the full range, given that each call generates 31 bits of random data and we only need 64 in total.
|
10

Here you go, this uses the crytpo services (not the Random class), which is (theoretically) a better RNG then the Random class. You could easily make this an extension of Random or make your own Random class where the RNGCryptoServiceProvider is a class-level object.

using System.Security.Cryptography;
public static Int64 NextInt64()
{
   var bytes = new byte[sizeof(Int64)];    
   RNGCryptoServiceProvider Gen = new RNGCryptoServiceProvider();
   Gen.GetBytes(bytes);    
   return BitConverter.ToInt64(bytes , 0);        
}

1 Comment

This is definitely worthwhile noting, although judging by the question the OP doesn't seem to care too greatly about the randomness of the generated numbers. Also it's important to realise that RNGCryptoServiceProvider is much slower than Random (though performance may or may not matter here).
6

You can use bit shift to put together a 64 bit random number from 31 bit random numbers, but you have to use three 31 bit numbers to get enough bits:

long r = rnd.Next();
r <<= 31;
r |= rnd.Next();
r <<= 31;
r |= rnd.Next();

Comments

5

I always use this to get my random seed (error checking removed for brevity):

m_randomURL = "https://www.random.org/cgi-bin/randnum?num=1&min=1&max=1000000000";
HttpWebRequest req = (HttpWebRequest)WebRequest.Create(m_randomURL);
StreamReader stIn = new StreamReader(req.GetResponse().GetResponseStream());
Random rand = new Random(Convert.ToInt32(stIn.ReadToEnd()));

random.org uses atmospheric noise to generate the randomness and is apparently used for lotteries and such.

Comments

3

You don't say how you're going to use these random numbers...keep in mind that values returned by Random are not "cryptographically secure" and they shouldn't be used for things involving (big) secrets or (lots of) money.

7 Comments

-1 for not mentioning the .Net Crypto RNG. msdn.microsoft.com/en-us/library/…
Why is that relevant? Dan alludes to the fact that a PC can't generate a cryptographically secure random number. The RNGCryptoServiceProvider class doesn't fix that.
And RNGCryptoServiceProvider generates cryptographically secure random numbers and satisfies that condition of his answer.
John Von Neumann: "Anyone who considers arithmetic methods of producing random digits is, of course, in a state of sin."
The asker did not mention he required a secure random number, but it is nice you pointed out that the Random class does not produce secure numbers, but you really should mention an alternative instead of leaving a dead end.
|
2

You could create a byte array, fill it with random data and then convert it to long (Int64) or ulong (UInt64).

byte[] buffer = new byte[sizeof(Int64)];
Random random = new Random();

random.NextBytes(buffer);
long signed = BitConverter.ToInt64(buffer, 0);

random.NextBytes(buffer);
long unsigned = BitConverter.ToUInt64(buffer, 0);

Comments

1

As of .NET 6, the Random class has a method for generating a random long.

var r = new Random();
long randomLong = r.NextInt64();

Comments

0

Another answer with RNGCryptoServiceProvider instead of Random. Here you can see how to remove the MSB so the result is always positive.

public static Int64 NextInt64()
{
    var buffer = new byte[8];
    new RNGCryptoServiceProvider().GetBytes(buffer);
    return BitConverter.ToInt64(buffer, 0) & 0x7FFFFFFFFFFFFFFF;
}

Comments

0

Any reason not to do this?

public static class RandomExtensions
{

public static long NextInt64(this Random random) 
    => (long)random.NextDouble(long.MaxValue);

public static long NextInt64(this Random random, long maxValue) 
    => (long)random.NextDouble(maxValue);

public static long NextInt64(this Random random, long minValue, long maxValue) 
    => (long)random.NextDouble(minValue, maxValue);

}

Technically there is a non-zero chance that low numbers get picked over high numbers, but it should be negligible. For true randomness you should use RNGCryptoServiceProvider anyway, so I doubt you should care.

Comments

-3
Random r=new Random();
int j=r.next(1,23);
Console.WriteLine(j);

1 Comment

the random class is used to randomly select the values.random class give a well environment to the user to do so

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.