C# Adding data to an array?

Question

My code below reads a file offset and writes the hexadecimal values to the "MyGlobals.Hexbytes" variable .... How could I get it to write into an array instead?

Many Thanks

MyGlobals.Mapsettings_filepath = "C:\\123.cfg";

///////////////////////////// Read in the selected //////////////

BinaryReader br = new BinaryReader(File.OpenRead(MyGlobals.Mapsettings_filepath),
System.Text.Encoding.BigEndianUnicode);

for (int a = 32; a <= 36; a++)
{
    br.BaseStream.Position = a;
    MyGlobals.Hexbytes += br.ReadByte().ToString("X2") + ",";
}

It is hard to tell what you want. Do you want to change MyGlobals.Hexbytes? And what type of array do you want? A byte array, a string array, etc? Please edit your question to add this information. — Merlyn Morgan-Graham
– Merlyn Morgan-Graham, Commented Jul 8, 2011 at 21:34

user447356 · Accepted Answer · 2011-07-08 21:32:32Z

1

Make MyGlobals.Hexbytes to be List<string> instead then:

br.BaseStream.Position = a;
MyGlobals.Hexbytes.Add(br.ReadByte().ToString("X2"));

Later to display it, use String.Join like this:

string myBytes = string.Join(",", MyGlobals.Hexbytes.ToArray());

answered Jul 8, 2011 at 21:32

user447356

Sign up to request clarification or add additional context in comments.

Comments

digEmAll · Accepted Answer · 2011-07-08 21:40:59Z

1

Array is a fixed size structure, so you cannot add elements to it.

If you know the size in advance (as it seems in your example) you can instanciate it and then add elements to the pre-allocated slots:

e.g.

string[] byteStrings = new string[5]; // 36 - 32 + 1 = 5 

for (int a = 32; a <= 36; a++)
{
   br.BaseStream.Position = a;
   byteStrings[a - 32] = br.ReadByte().ToString("X2");
}

But it's much easier to use a dynamically-resizable collection, like List<T>:

var byteStrings = new List<string>();
for (int a = 32; a <= 36; a++)
{
   br.BaseStream.Position = a;
   byteStrings.Add(br.ReadByte().ToString("X2"));
}

edited Jul 8, 2011 at 21:40

answered Jul 8, 2011 at 21:33

digEmAll

57.3k9 gold badges118 silver badges142 bronze badges

2 Comments

user826436 Over a year ago

Thanks for the replies...Is there anyway I can read 4bytes in instead of just one byte each time?

svick Over a year ago

@user, what difference does it make?

Adriano Carneiro · Accepted Answer · 2011-07-08 21:39:11Z

0

Assuming MyGlobals.Hexbytes, which is likely, you could leave your code the way it is and add this in the end:

var myarray = MyGlobals.Hexbytes.Split(',');

myarray is an array of string.

answered Jul 8, 2011 at 21:39

Adriano Carneiro

58.8k12 gold badges94 silver badges123 bronze badges

Comments

platon · Accepted Answer · 2011-07-08 21:55:02Z

0

You should first define the size of the array and thus you should first set its size and then populate it:

string[] array = new string[5];

for (int a = 32; a <= 36; a++)
{
    br.BaseStream.Position = a;
    array[a - 32] += br.ReadByte().ToString("X2");
}

Here is how to read 4 bytes at once:

            BinaryReader reader = ....;
...
            byte[] buffer = new byte[4];
            reader.Read(buffer, 0, 4);

...

edited Jul 8, 2011 at 21:55

answered Jul 8, 2011 at 21:36

platon

5,3801 gold badge24 silver badges25 bronze badges

1 Comment

platon Over a year ago

@user826436, I updated my answer with the code to read 4 bytes using binaryreader

Collectives™ on Stack Overflow

C# Adding data to an array?

4 Answers 4

Comments

2 Comments

Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

1 Comment

Related