adding row to table

Question

When i use this line of code row is getting added in table

$('#preq > tbody:last').append('<tr><td>Added here</td></tr>');

but when i use it for this it is not working

$('#preq > tbody:last').append('<tr><td><input title="Enter Kind Of work new" readonly="readonly" onclick="if(this.value!=''){this.value='';opendrop();}else{opendrop();}" id="other_work5" name="other_work5" type="text" size="30" onclick="opendrop()"  <?php if (isset($errors)) { echo 'value="'.htmlentities(@$_POST['other_workn']).'"'; } ?>></td><td><input name="client_name5" type="text" id="client_name5" size="40"/></td><td><input name="firm_name5" type="text" id="firm_name5" size="40"/></td></tr>');

where is the mistake?

and it's better to use some IDE or editor which will highlight your errors, to prevent such simple cases — llamerr
– llamerr, Commented Jan 4, 2013 at 8:59
actually i am new to coding ,so can you suggest any such good editor,because in my editor it didn't show me this error — raj
– raj, Commented Jan 4, 2013 at 9:46

Praveen Kumar Purushothaman · Accepted Answer · 2013-01-04 07:45:03Z

Unescaped string:

$('#preq > tbody:last').append('<tr><td><input title="Enter Kind Of work new" readonly="readonly" onclick="if(this.value!='')
--------------------------------------------^ {this.value='';opendrop();}else{opendrop();}" id="other_work5"
------------^
name="other_work5" type="text" size="30" onclick="opendrop()" <?php if (isset($errors)) { echo 'value="'.htmlentities(@$_POST['other_workn']).'"'; } ?>></td><td><input name="client_name5" type="text" id="client_name5" size="40"/></td><td><input name="firm_name5" type="text" id="firm_name5" size="40"/></td></tr>');

Just escape them using \' and you are good!

Working one:

$('#preq > tbody:last').append('<tr><td><input title="Enter Kind Of work new" readonly="readonly" onclick="if(this.value!=\'\'){this.value=\'\';opendrop();}else{opendrop();}" id="other_work5" name="other_work5" type="text" size="30" onclick="opendrop()" <?php if (isset($errors)) { echo 'value="'.htmlentities(@$_POST['other_workn']).'"'; } ?>></td><td><input name="client_name5" type="text" id="client_name5" size="40"/></td><td><input name="firm_name5" type="text" id="firm_name5" size="40"/></td></tr>');

Introducing another programming language layer for something so mudane is like exterminating ants with nuclear warheads. This will work, but makes everything unneccessarily complicated. It also is a perfect rip-off of the code of MrXenotype.

llamerr · Accepted Answer · 2013-01-04 08:52:15Z

You need to escape your single quotes. Try this:

$('#preq > tbody:last').append('' +
  '<tr>' +
    '<td>' +
      '<input title="Enter Kind Of work new" readonly="readonly" ' +
        'onclick="if(this.value!=\'\'){this.value=\'\';opendrop();}else{opendrop();}" id="other_work5" name="other_work5" type="text" size="30" ' +
        'onclick="opendrop()"  <?php if (isset($errors)) { echo 'value="'.htmlentities(@$_POST['other_workn']).'"'; } ?>>' +
    '</td>' +
    '<td>' +
      '<input name="client_name5" type="text" id="client_name5" size="40"/>' +
    '</td>' +
    '<td>' +
      '<input name="firm_name5" type="text" id="firm_name5" size="40"/>' +
    '</td>' +
  '</tr>'
);

Please also note that the php will be executed before the html is appended since PHP is server side...

alizahid · Accepted Answer · 2013-01-04 07:45:13Z

1

Unescaped single quotes inside your code surrounded by single quotes.

answered Jan 4, 2013 at 7:45

alizahid

9697 silver badges17 bronze badges

Comments

ty812 · Accepted Answer · 2013-01-04 07:45:19Z

0

The first single quote (') in

"if(this.value!='')

closes the string opened with

append('

Escape all single quotes in the string you want to append.

answered Jan 4, 2013 at 7:45

ty812

3,33322 silver badges36 bronze badges

Collectives™ on Stack Overflow

adding row to table

4 Answers 4

Unescaped string:

Working one:

2 Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Unescaped string:

Working one:

2 Comments

Comments

Comments

Comments

Related