Skip to content

Fix removing whitespacing in dev overlay #28277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 10 commits into from
Aug 8, 2022
Merged

Fix removing whitespacing in dev overlay #28277

kodiakhq merged 10 commits into from
Aug 8, 2022

Conversation

@dikwickley
Copy link
Contributor

@dikwickley dikwickley commented Aug 19, 2021 •
edited
Loading

Bug

  • Related issues linked using fixes #number

fixes #14434

Before
image

After
image
@dikwickley dikwickley changed the title fix for issue #14434 fix for issue #14434 whitespacing in error pop up Aug 19, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Sep 2, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
buildDuration 12.3s 12.2s -125ms
buildDurationCached 3.1s 3.2s ⚠️ +99ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +169 B
Page Load Tests Overall increase ✓
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.324 2.314 -0.01
/ avg req/sec 1075.62 1080.42 +4.8
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.316 1.281 -0.04
/error-in-render avg req/sec 1900.16 1952.06 +51.9
Client Bundles (main, webpack, commons)
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
745.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 23.3 kB 23.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 67.2 kB 67.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
_app-HASH.js gzip 979 B 979 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.67 kB 2.67 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 918 B 918 B ✓
image-HASH.js gzip 4.14 kB 4.14 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 318 B 318 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 13 kB 13 kB ✓
Client Build Manifests
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
_buildManifest.js gzip 492 B 492 B ✓
Overall change 492 B 492 B ✓
Rendered Page Sizes
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
index.html gzip 539 B 539 B ✓
link.html gzip 552 B 552 B ✓
withRouter.html gzip 534 B 534 B ✓
Overall change 1.63 kB 1.63 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
buildDuration 10.1s 9.8s -287ms
buildDurationCached 4.2s 4.2s -13ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +169 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.371 2.415 ⚠️ +0.04
/ avg req/sec 1054.36 1035.29 ⚠️ -19.07
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.31 1.312 0
/error-in-render avg req/sec 1908.52 1905.01 ⚠️ -3.51
Client Bundles (main, webpack, commons)
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
16.HASH.js gzip 186 B 186 B ✓
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB ✓
framework.HASH.js gzip 41.9 kB 41.9 kB ✓
main-HASH.js gzip 10.7 kB 10.7 kB ✓
webpack-HASH.js gzip 1.19 kB 1.19 kB ✓
Overall change 68.1 kB 68.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
_app-HASH.js gzip 964 B 964 B ✓
_error-HASH.js gzip 3.8 kB 3.8 kB ✓
amp-HASH.js gzip 552 B 552 B ✓
css-HASH.js gzip 333 B 333 B ✓
dynamic-HASH.js gzip 2.87 kB 2.87 kB ✓
head-HASH.js gzip 3.06 kB 3.06 kB ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 231 B 231 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 298 B 298 B ✓
script-HASH.js gzip 3.03 kB 3.03 kB ✓
withRouter-HASH.js gzip 295 B 295 B ✓
30809af5c834..565.css gzip 125 B 125 B ✓
Overall change 18.1 kB 18.1 kB ✓
Client Build Manifests
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
_buildManifest.js gzip 500 B 500 B ✓
Overall change 500 B 500 B ✓
Rendered Page Sizes
vercel/next.js canary DiKwickley/next.js fix-#14434 Change
index.html gzip 586 B 586 B ✓
link.html gzip 598 B 598 B ✓
withRouter.html gzip 579 B 579 B ✓
Overall change 1.76 kB 1.76 kB ✓
Commit: 33f0c6a
@ijjk ijjk changed the title fix for issue #14434 whitespacing in error pop up Fix removing whitespacing in dev overlay Aug 8, 2022
ijjk
ijjk approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@kodiakhq kodiakhq bot merged commit 8ddcc6a into vercel:canary Aug 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: next

2 participants

@dikwickley @ijjk