Disallow --unique alongside --ignore-cases in file-contents-sorter#1095
Merged
Conversation
Closes #794: using these flags at the same time results in undefined behavior - the final ordering is not guaranteed as --unique breaks sorting due to passing the contents through a set. NOTE: I added a newline before and after the mutex group to be consistent with other usages of mutex groups (e.g., check_builtin_literals.py) in this repo.
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Aug 11, 2025
… (hetznercloud/fleeting-plugin-hetzner!264) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit/pre-commit-hooks](https://github.com/pre-commit/pre-commit-hooks) | repository | major | `v5.0.0` -> `v6.0.0` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)</summary> ### [`v6.0.0`](https://github.com/pre-commit/pre-commit-hooks/releases/tag/v6.0.0): pre-commit-hooks v6.0.0 [Compare Source](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) #### Fixes - `check-shebang-scripts-are-executable`: improve error message. - [#​1115](pre-commit/pre-commit-hooks#1115) MR by [@​homebysix](https://github.com/homebysix). #### Migrating - now requires python >= 3.9. - [#​1098](pre-commit/pre-commit-hooks#1098) MR by [@​asottile](https://github.com/asottile). - `file-contents-sorter`: disallow `--unique` and `--ignore-case` at the same time. - [#​1095](pre-commit/pre-commit-hooks#1095) MR by [@​nemacysts](https://github.com/nemacysts). - [#​794](pre-commit/pre-commit-hooks#794) issue by [@​teksturi](https://github.com/teksturi). - Removed `check-byte-order-marker` and `fix-encoding-pragma`. - `check-byte-order-marker`: migrate to `fix-byte-order-marker`. - `fix-encoding-pragma`: migrate to `pyupgrade`. - [#​1034](pre-commit/pre-commit-hooks#1034) MR by [@​mxr](https://github.com/mxr). - [#​1032](pre-commit/pre-commit-hooks#1032) issue by [@​mxr](https://github.com/mxr). - [#​522](pre-commit/pre-commit-hooks#522) MR by [@​jgowdy](https://github.com/jgowdy). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MS4xIiwidXBkYXRlZEluVmVyIjoiNDEuNjEuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
pat-s
pushed a commit
to devxygmbh/ansible-data-science-core
that referenced
this pull request
Jan 22, 2026
… (#72) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit/pre-commit-hooks](https://github.com/pre-commit/pre-commit-hooks) | repository | major | `v5.0.0` -> `v6.0.0` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)</summary> ### [`v6.0.0`](https://github.com/pre-commit/pre-commit-hooks/releases/tag/v6.0.0): pre-commit-hooks v6.0.0 [Compare Source](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) #### Fixes - `check-shebang-scripts-are-executable`: improve error message. - [#​1115](pre-commit/pre-commit-hooks#1115) PR by [@​homebysix](https://github.com/homebysix). #### Migrating - now requires python >= 3.9. - [#​1098](pre-commit/pre-commit-hooks#1098) PR by [@​asottile](https://github.com/asottile). - `file-contents-sorter`: disallow `--unique` and `--ignore-case` at the same time. - [#​1095](pre-commit/pre-commit-hooks#1095) PR by [@​nemacysts](https://github.com/nemacysts). - [#​794](pre-commit/pre-commit-hooks#794) issue by [@​teksturi](https://github.com/teksturi). - Removed `check-byte-order-marker` and `fix-encoding-pragma`. - `check-byte-order-marker`: migrate to `fix-byte-order-marker`. - `fix-encoding-pragma`: migrate to `pyupgrade`. - [#​1034](pre-commit/pre-commit-hooks#1034) PR by [@​mxr](https://github.com/mxr). - [#​1032](pre-commit/pre-commit-hooks#1032) issue by [@​mxr](https://github.com/mxr). - [#​522](pre-commit/pre-commit-hooks#522) PR by [@​jgowdy](https://github.com/jgowdy). </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MC4zIiwidXBkYXRlZEluVmVyIjoiNDEuNjAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://codefloe.com/devxy/ansible-data-science-core/pulls/72 Co-authored-by: devxy-bot <no-reply@devxy.io> Co-committed-by: devxy-bot <no-reply@devxy.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #794: using these flags at the same time results in undefined behavior - the final ordering is not guaranteed as --unique breaks sorting due to passing the contents through a set.
NOTE: I added a newline before and after the mutex group to be consistent with other usages of mutex groups (e.g., check_builtin_literals.py) in this repo.