Skip to content

Remove check-byte-order-marker and fix-encoding-pragma#1034

Merged
asottile merged 1 commit into
mainfrom
remove-fix-encoding-pragma
May 25, 2025
Merged

Remove check-byte-order-marker and fix-encoding-pragma#1034
asottile merged 1 commit into
mainfrom
remove-fix-encoding-pragma

Conversation

@mxr

@mxr mxr commented Apr 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Resolves #1032

$  pre-commit try-repo . check-byte-order-marker --files setup.py ; pre-commit try-repo . fix-encoding-pragma --files setup.py
===============================================================================
Using config:
===============================================================================
repos:
-   repo: .
    rev: 5920aee766fa13b4fe8b1727ffa46495c151e24b
    hooks:
    -   id: check-byte-order-marker
===============================================================================
[INFO] Initializing environment for ..
[INFO] Installing environment for ..
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Using pre-commit with uv 0.6.14 via pre-commit-uv 4.1.4
check-byte-order-marker (removed)........................................Failed
- hook id: check-byte-order-marker
- exit code: 1

`check-byte-order-marker` has been removed -- use `fix-byte-order-marker` from https://github.com/pre-commit/pre-commit-hooks

===============================================================================
Using config:
===============================================================================
repos:
-   repo: .
    rev: 5920aee766fa13b4fe8b1727ffa46495c151e24b
    hooks:
    -   id: fix-encoding-pragma
===============================================================================
[INFO] Initializing environment for ..
[INFO] Installing environment for ..
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Using pre-commit with uv 0.6.14 via pre-commit-uv 4.1.4
fix python encoding pragma (removed).....................................Failed
- hook id: fix-encoding-pragma
- exit code: 1

`fix-encoding-pragma` has been removed -- use `pyupgrade` from https://github.com/asottile/pyupgrade
@asottile asottile force-pushed the fix-encoding-pragma branch from 3285353 to cef973f Compare April 6, 2024 18:10
Base automatically changed from fix-encoding-pragma to main April 6, 2024 18:12
@mxr mxr force-pushed the remove-fix-encoding-pragma branch 2 times, most recently from 37ae88d to b2bb193 Compare April 11, 2024 01:52
@mxr mxr requested a review from asottile March 4, 2025 22:31
@asottile

asottile commented May 23, 2025

Copy link
Copy Markdown
Member

a year late to this but -- let's use pre-commit-hooks-removed for at least a version so people are notified instead of autoupdate just stalling

we can also do this for check-byte-order-marker at the same time
@mxr mxr force-pushed the remove-fix-encoding-pragma branch from cfe7323 to a1b31bd Compare May 25, 2025 14:55
@mxr mxr changed the title Delete fix-encoding-pragma hook Mark check-byte-ordering and fix-encoding-pragma as removed May 25, 2025
@mxr mxr force-pushed the remove-fix-encoding-pragma branch 2 times, most recently from 3c87799 to 5eff2a3 Compare May 25, 2025 14:58
@mxr mxr changed the title Mark check-byte-ordering and fix-encoding-pragma as removed Mark check-byte-order-marker and fix-encoding-pragma as removed May 25, 2025
@mxr mxr force-pushed the remove-fix-encoding-pragma branch 2 times, most recently from b318b47 to 0b0e2b9 Compare May 25, 2025 15:01
@mxr mxr changed the title Mark check-byte-order-marker and fix-encoding-pragma as removed Remove check-byte-order-marker and fix-encoding-pragma May 25, 2025
@mxr mxr force-pushed the remove-fix-encoding-pragma branch from 0b0e2b9 to 5920aee Compare May 25, 2025 15:03
@mxr

mxr commented May 25, 2025

Copy link
Copy Markdown
Member Author

@asottile sure, updated
@mxr

mxr commented May 25, 2025

Copy link
Copy Markdown
Member Author

And removed the code (let me know if I misunderstood)
@asottile asottile merged commit 2a9bc76 into main May 25, 2025
8 checks passed
@asottile asottile deleted the remove-fix-encoding-pragma branch May 25, 2025 15:10
@mxr

mxr commented May 25, 2025

Copy link
Copy Markdown
Member Author

no cat gif?
@asottile

asottile commented May 25, 2025

Copy link
Copy Markdown
Member

on my phone, here you go!

@mxr

mxr commented May 25, 2025

Copy link
Copy Markdown
Member Author

woo!
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Aug 11, 2025
@jooola
chore(deps): update pre-commit hook pre-commit/pre-commit-hooks to v6…
5567f57 
… (hetznercloud/fleeting-plugin-hetzner!264)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pre-commit/pre-commit-hooks](https://github.com/pre-commit/pre-commit-hooks) | repository | major | `v5.0.0` -> `v6.0.0` |

Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions.

---

### Release Notes

<details>
<summary>pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)</summary>

### [`v6.0.0`](https://github.com/pre-commit/pre-commit-hooks/releases/tag/v6.0.0): pre-commit-hooks v6.0.0

[Compare Source](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0)

#### Fixes

- `check-shebang-scripts-are-executable`: improve error message.
  - [#&#8203;1115](pre-commit/pre-commit-hooks#1115) MR by [@&#8203;homebysix](https://github.com/homebysix).

#### Migrating

- now requires python >= 3.9.
  - [#&#8203;1098](pre-commit/pre-commit-hooks#1098) MR by [@&#8203;asottile](https://github.com/asottile).
- `file-contents-sorter`: disallow `--unique` and `--ignore-case` at the same
  time.
  - [#&#8203;1095](pre-commit/pre-commit-hooks#1095) MR by [@&#8203;nemacysts](https://github.com/nemacysts).
  - [#&#8203;794](pre-commit/pre-commit-hooks#794) issue by [@&#8203;teksturi](https://github.com/teksturi).
- Removed `check-byte-order-marker` and `fix-encoding-pragma`.
  - `check-byte-order-marker`: migrate to `fix-byte-order-marker`.
  - `fix-encoding-pragma`: migrate to `pyupgrade`.
  - [#&#8203;1034](pre-commit/pre-commit-hooks#1034) MR by [@&#8203;mxr](https://github.com/mxr).
  - [#&#8203;1032](pre-commit/pre-commit-hooks#1032) issue by [@&#8203;mxr](https://github.com/mxr).
  - [#&#8203;522](pre-commit/pre-commit-hooks#522) MR by [@&#8203;jgowdy](https://github.com/jgowdy).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MS4xIiwidXBkYXRlZEluVmVyIjoiNDEuNjEuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
ulgens added a commit to ulgens/django-docker-box that referenced this pull request Nov 22, 2025
@ulgens
Replace deprecated hook with pyupgrade
54067d3 
pre-commit/pre-commit-hooks#1034

> ### Deprecated / replaced hooks
> - `check-byte-order-marker`: instead use fix-byte-order-marker
> - `fix-encoding-pragma`: instead use [`pyupgrade`](https://github.com/asottile/pyupgrade)
ulgens added a commit to ulgens/django-docker-box that referenced this pull request Nov 22, 2025
@ulgens
Replace deprecated hook with pyupgrade
055ff6f 
pre-commit/pre-commit-hooks#1034

> ### Deprecated / replaced hooks
> - `check-byte-order-marker`: instead use fix-byte-order-marker
> - `fix-encoding-pragma`: instead use [`pyupgrade`](https://github.com/asottile/pyupgrade)
@ttys0dev ttys0dev mentioned this pull request Jan 9, 2026
Merged
pat-s pushed a commit to devxygmbh/ansible-data-science-core that referenced this pull request Jan 22, 2026
chore(deps): update pre-commit hook pre-commit/pre-commit-hooks to v6…
d41b62e 
… (#72)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pre-commit/pre-commit-hooks](https://github.com/pre-commit/pre-commit-hooks) | repository | major | `v5.0.0` -> `v6.0.0` |

Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions.

---

### Release Notes

<details>
<summary>pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)</summary>

### [`v6.0.0`](https://github.com/pre-commit/pre-commit-hooks/releases/tag/v6.0.0): pre-commit-hooks v6.0.0

[Compare Source](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0)

#### Fixes

- `check-shebang-scripts-are-executable`: improve error message.
  - [#&#8203;1115](pre-commit/pre-commit-hooks#1115) PR by [@&#8203;homebysix](https://github.com/homebysix).

#### Migrating

- now requires python >= 3.9.
  - [#&#8203;1098](pre-commit/pre-commit-hooks#1098) PR by [@&#8203;asottile](https://github.com/asottile).
- `file-contents-sorter`: disallow `--unique` and `--ignore-case` at the same
  time.
  - [#&#8203;1095](pre-commit/pre-commit-hooks#1095) PR by [@&#8203;nemacysts](https://github.com/nemacysts).
  - [#&#8203;794](pre-commit/pre-commit-hooks#794) issue by [@&#8203;teksturi](https://github.com/teksturi).
- Removed `check-byte-order-marker` and `fix-encoding-pragma`.
  - `check-byte-order-marker`: migrate to `fix-byte-order-marker`.
  - `fix-encoding-pragma`: migrate to `pyupgrade`.
  - [#&#8203;1034](pre-commit/pre-commit-hooks#1034) PR by [@&#8203;mxr](https://github.com/mxr).
  - [#&#8203;1032](pre-commit/pre-commit-hooks#1032) issue by [@&#8203;mxr](https://github.com/mxr).
  - [#&#8203;522](pre-commit/pre-commit-hooks#522) PR by [@&#8203;jgowdy](https://github.com/jgowdy).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MC4zIiwidXBkYXRlZEluVmVyIjoiNDEuNjAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Reviewed-on: https://codefloe.com/devxy/ansible-data-science-core/pulls/72
Co-authored-by: devxy-bot <no-reply@devxy.io>
Co-committed-by: devxy-bot <no-reply@devxy.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@mxr @asottile @SpecK87