fix(php): update array_filter signature parameter from flag to mode#326252
Open
jonkloske wants to merge 2 commits into
Open
fix(php): update array_filter signature parameter from flag to mode#326252jonkloske wants to merge 2 commits into
jonkloske wants to merge 2 commits into
Conversation
PHP 8.0+ named arguments throw a Fatal Error if 'flag:' is passed because the internal engine compiles the variable as 'mode'. Updating the built-in language feature string to prevent misleading IDE suggestions.
jonkloske
added a commit
to jonkloske/vscode
that referenced
this pull request
Jul 17, 2026
Updated the signature parameter from 'userdata' to 'arg' for array_walk_recursive and array_walk functions. This is again due to the change in doco with the PHP8 "named parameter" release. Similar to microsoft#326252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.0+ named arguments throw a Fatal Error if 'flag:' is passed because the internal engine compiles the variable as 'mode'. Updating the built-in language feature string to prevent misleading IDE suggestions. Trivial parameter rename, was a doco/code issue until PHP8 named parameters forced a doco change. Currently available at https://www.php.net/manual/en/function.array-filter.php to confirm.