User Details
- User Since
- Oct 27 2014, 6:03 PM (579 w, 2 d)
- Availability
- Available
- IRC Nick
- edsanders
- LDAP User
- Esanders
- MediaWiki User
- ESanders (WMF) [ Global Accounts ]
Yesterday
It looks like the links in the "new" document aren't being sanitized and having their data-parsoid id's removed, so <a href="..."> !== <a id="mw..." href="...">
🕯️ Goodbye Flow...
Having the expand buttons load earlier is a separate issue and more complex. The above patch ensures the edit pencils are never visible.
The intrusion seems pretty minimal. We could either reduce the outline to 1px, or use semi-transparent black instead of grey for the colour.
FYI you can also test by just adding the relevant class: $('html').addClass('ve-loading')
Mon, Dec 1
Can't be tested in VE until we do an OOUI release.
Fixed
As noted in T411358, other parts of the interface use usernames scraped from the wikitext, such as the "Latest comment" headings. If we were to follow redirects then these should be updated too.
Yes - this reason is the same as this comment: T267839#6625654
Fri, Nov 28
Note also that ellipsis truncation is how we drop regular DropdownWidgets.
Of these pages only https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas has had any meaningful activity in the last 5 years, so I will try to manually move that one, and the others can be frozen in place when we set Flow to readonly.
The move script is completed. 50 page were skipped for either being "standalone Flow pages" (in a subject namespace) or having no associated subject page:
Skipped 'Wikilivros:Plantão de dúvidas' as it is a standalone Flow page Skipped 'Utilizador:Alustriel/Arquivo 3' as it is a standalone Flow page Skipped 'Wikilivros:Enquete' as it is a standalone Flow page Skipped 'Wikilivros:Predefinições/Discussões' as it is a standalone Flow page Skipped 'Wikilivros:LiquidThreads' as it is a standalone Flow page Skipped 'Wikilivros:Comentários' as it is a standalone Flow page Skipped 'Wikilivros:Robôs' as it is a standalone Flow page Skipped 'Wikilivros:Filtro de edições/Problemas' as it is a standalone Flow page Skipped 'Wikilivros:Filtro de edições/Pedidos' as it is a standalone Flow page Skipped 'Discussão:Teste' as it has no associated subject page Skipped 'Discussão:Introdução' as it has no associated subject page Skipped 'Discussão:Java/O porquê de se estudar Java' as it has no associated subject page Skipped 'Discussão:Logística/Arquivo' as it has no associated subject page Skipped 'Discussão:Larry David' as it has no associated subject page Skipped 'Discussão:Suor Angelica' as it has no associated subject page Skipped 'Discussão:YDreams' as it has no associated subject page Skipped 'Discussão:Etano' as it has no associated subject page Skipped 'Discussão:Louis Vuitton' as it has no associated subject page Skipped 'Discussão:Referência rápida de C++/' as it has no associated subject page Skipped 'Wikilivros Discussão:Portal comunitário/Arquivo/Página' as it has no associated subject page Skipped 'Wikilivros Discussão:Wikilivros:Diálogos comunitários/Arquivo/Diálogos comunitários-Discussão' as it has no associated subject page Skipped 'Wikilivros Discussão:Wikilivros:Diálogos comunitários/Arquivo/Diálogos comunitários-Discussão/Arquivo' as it has no associated subject page Skipped 'Wikilivros Discussão:Página principal/Arquivo 2' as it has no associated subject page Skipped 'Wikilivros Discussão:Página principal/Arquivo 3' as it has no associated subject page Skipped 'Wikilivros Discussão:Página principal/Arquivo 4' as it has no associated subject page Skipped 'Wikilivros Discussão:Pedidos de eliminação de páginas/Arquivo 1' as it has no associated subject page Skipped 'Wikilivros Discussão:Biblioteca/Arquivo' as it has no associated subject page Skipped 'Ficheiro Discussão:Gazpar2dmod.gif' as it has no associated subject page Skipped 'Ficheiro Discussão:Gazpar3d.gif' as it has no associated subject page Skipped 'Ficheiro Discussão:Como usar Blueprints 01.jpg' as it has no associated subject page Skipped 'Ficheiro Discussão:Pentagono regular e seus elementos.svg' as it has no associated subject page Skipped 'MediaWiki Discussão:Whatlinkshere' as it has no associated subject page Skipped 'MediaWiki Discussão:Copyrightwarning' as it has no associated subject page Skipped 'MediaWiki Discussão:PDF Template Blacklist' as it has no associated subject page Skipped 'MediaWiki Discussão:Newsectionsummary' as it has no associated subject page Skipped 'MediaWiki Discussão:Livros' as it has no associated subject page Skipped 'MediaWiki Discussão:Common.js/Topo' as it has no associated subject page Skipped 'MediaWiki Discussão:Pageinfo-footer' as it has no associated subject page Skipped 'MediaWiki Discussão:Welcomecreation' as it has no associated subject page Skipped 'Discussão:Vegetarianismo/Malefícios do Carnivorismo' as it has no associated subject page Skipped 'Discussão:Luis Banda Capenba' as it has no associated subject page Skipped 'Discussão:Silo Meno' as it has no associated subject page Skipped 'Discussão:Italiano/Aula1' as it has no associated subject page Skipped 'Discussão:Denkou Choujin: Gridman' as it has no associated subject page Skipped 'Discussão:Valter Bitencourt Júnior' as it has no associated subject page Skipped 'Discussão:Factos que você não sabia sobre a Desciclopedia!' as it has no associated subject page Skipped 'Discussão:Ricardo Pavanelly' as it has no associated subject page Skipped 'Discussão:Russo/Exercícios/Caso prepositivo' as it has no associated subject page Skipped 'Discussão:Peeragogy Handbook V1.1 (pt-Brazilian)' as it has no associated subject page Skipped 'Discussão:Dicionário Brasileiro de Linguagem Jurídica/Fale conosco' as it has no associated subject page
The above patch implements the GoogleDocs solution (2).
Thu, Nov 27
This has resolved all the issues I was seeing on ptwikibooks.
@matmarex spotted this in T368179#9918653, but I think we though it was an edge case in external links...
Bisect blames OOUI 0.50.2 https://gerrit.wikimedia.org/g/oojs/ui/+/v0.50.2/History.md so most likely "Dialog: Check if an action is disabled in the UI before executing"
The move script has resumed and appears to be working:
Moved 'Utilizador Discussão:Rafael Canhête L. Filho' to 'Utilizador Discussão:Rafael Canhête L. Filho/Flow' Created stub at 'Utilizador Discussão:Rafael Canhête L. Filho' Moved 'Utilizador Discussão:Julia~ptwikibooks' to 'Utilizador Discussão:Julia~ptwikibooks/Flow' Created stub at 'Utilizador Discussão:Julia~ptwikibooks' Moved 'Utilizador Discussão:Juulinha' to 'Utilizador Discussão:Juulinha/Flow' Created stub at 'Utilizador Discussão:Juulinha' Moved 'Utilizador Discussão:Jonas AGX' to 'Utilizador Discussão:Jonas AGX/Flow' Created stub at 'Utilizador Discussão:Jonas AGX' Moved 'Wikilivros Discussão:Portal comunitário/Apresente-se' to 'Wikilivros Discussão:Portal comunitário/Apresente-se/Flow' Created stub at 'Wikilivros Discussão:Portal comunitário/Apresente-se' Moved 'Utilizador Discussão:Julimaq' to 'Utilizador Discussão:Julimaq/Flow' Created stub at 'Utilizador Discussão:Julimaq' Moved 'Utilizador Discussão:Franprarod' to 'Utilizador Discussão:Franprarod/Flow' Created stub at 'Utilizador Discussão:Franprarod' Moved 'Utilizador Discussão:GArantes' to 'Utilizador Discussão:GArantes/Flow' Created stub at 'Utilizador Discussão:GArantes' ...
The Parsoid fix was deployed and the broken board moves have all been fixed. Re-running the move script...
The same applies on desktop. I think at some point we made this happen deliberately as we were planning on the revising state of the card being significantly different to the inital state, but we ended up with the two states being nearly identical but for the first button. Given that it probably makes sense to switch the card to the revising state as soon as the user starts typing.
Wed, Nov 26
Belatedly scheduled for tomorrow 27th November.
FlowFixInconsistentBoards detects this broken boards in a dry run, but when trying to actually fix, triggers the same Parsoid error as above. Looks like we will need to get that Parsoid fix deployed, then fix the boards, then try the moves again.
This looks a lot like T371769: Moving a Flow discussion page can render it inaccessible
So for these pages, there is an entry in the page table with a page_title of <old title> and there is an entry in flow_workflow withe workflow_title_text of <old title>/Flow. Which suggests that the page has only been partially moved.
After the first ~4,000 flow boards moved successfully, we appear to have thousands of broken Flow boards now:
Tue, Nov 25
I think the issue here is that going from selecting an image to selecting the whole page causes the image context to close and that triggers a scroll-into-view.
This should be handled by your app, not the UI library.
The complexity here is coming from collapsing the edit check in mid-edit. I think this functionality should never have existed and got copied over from the pre-save moment without consideration.
This already behaves as expected for me
- The keyboard is hidden.
This already behaves as expected for me
- The bottom sheet should always expand fully so the user can easily view the information from the Check.
This needs to be fixed, an is the same as (3) below
- When the Check is expanded and the user starts typing:
- The keyboard opens.
The user can't start typing unless the keyboard is already open.
- The bottom passes from expanded to collapsed, allowing the user to type while keeping the Check available but not distracting.
The check is fully hidden when the keyboard is opened, which is as expected
- When the user clicks the Check icon (trigger), the bottom sheet should always expand.
- If the bottom sheet was not displayed, it appears.
- If the bottom sheet was collapsed, it expands.
See above.
border-color-subtle, along with the small OOUI drop shadow, is the same as used by the toolbar and the mobile context, which this component mimics:
Mon, Nov 24
Placing the [edit] link to the left of the infobox is actually technically quite complex and the WIP patch already shows some of this https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1207828. Aside from the fact that we are placing more UI within the content area, which will require some review by the Content Transform Team, it is essentially the same problem as lede-paragraph hoisting that is done on Mobile Web and Mobile Apps. Web and apps have slightly different implementations and neither are perfect. There is also some tech debt around those as well as outstanding tasks to unify the logic (T277367, T359002).
We've come across a few pages (2 in the first 4,000) that trigger an exception in Parsoid, probably due to using and old version of Parsoid HTML:
UnexpectedValueException from line 730 of /srv/mediawiki/php-1.46.0-wmf.3/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php: Unable to decode data-mw [{"parts":[{"template":{"target":{"wt":"fullurl:User talk:Raylton P. Sousa","function":"fullurl"},"params":{"action":{"wt":"edit§ion=new"}},"i":0}}]}]
#0 /srv/mediawiki/php-1.46.0-wmf.3/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php(674): Wikimedia\Parsoid\Utils\DOMDataUtils::loadDataAttribs(Object(Wikimedia\Parsoid\DOM\Element), Array)
#1 /srv/mediawiki/php-1.46.0-wmf.3/vendor/wikimedia/parsoid/src/Utils/DOMUtils.php(73): Wikimedia\Parsoid\Utils\DOMDataUtils::Wikimedia\Parsoid\Utils\{closure}(Object(Wikimedia\Parsoid\DOM\Element), Array)
#2 /srv/mediawiki/php-1.46.0-wmf.3/vendor/wikimedia/parsoid/src/Utils/DOMUtils.php(77): Wikimedia\Parsoid\Utils\DOMUtils::visitDOM(Object(Wikimedia\Parsoid\DOM\Element), Object(Closure), Array)
#3 /srv/mediawiki/php-1.46.0-wmf.3/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php(673): Wikimedia\Parsoid\Utils\DOMUtils::visitDOM(Object(Wikimedia\Parsoid\DOM\Element), Object(Closure), Array)
#4 /srv/mediawiki/php-1.46.0-wmf.3/vendor/wikimedia/parsoid/src/Utils/ContentUtils.php(101): Wikimedia\Parsoid\Utils\DOMDataUtils::visitAndLoadDataAttribs(Object(Wikimedia\Parsoid\DOM\DocumentFragment), Array)
#5 /srv/mediawiki/php-1.46.0-wmf.3/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php(167): Wikimedia\Parsoid\Utils\ContentUtils::createAndLoadDocumentFragment(Object(Wikimedia\Parsoid\DOM\Document), '<span about="#m...', Array)Fri, Nov 21
This is part of the editor, so Editing can fix. It's a regression but not critical, and Parsoid read views are not widely available yet.
Scheduled for Monday 24th 140UTC.
At current count there are 385 instances of <ce> and 10,000+ instances of <chem>. I think we just need someone to run a bulk edit to fix these.
Thu, Nov 20
One page archived as a test: https://pt.wikibooks.org/wiki/Utilizador_Discuss%C3%A3o:Roan_Kattouw_(WMF)