Create Task
Maniphest T433773

"Fold all ref tags by default" when enabled in WikiEditor causes layout issues in 2017 wikitext editor
Open, Needs TriagePublic
Actions

Description

  1. Visit a page using WikiEditor: https://en.wikipedia.org/wiki/Introduced_species?action=edit&venoautoload
  2. Enable syntax highlighting, open the full codemirror preferences, enable "Fold all <ref> tags by default (potentially slow)"
  3. Visit a page using the 2017 wikitext editor: https://en.wikipedia.org/wiki/Introduced_species?veaction=editsource
  4. Observe collapsed <ref> tags
  5. Click into the surface, and observe overlap glitches

CleanShot 2026-08-01 at 12.08.20@2x.png (1,930×560 px, 275 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Preferences: honour the VE allowlist for callback preferencesDLynchmediawiki/extensions/CodeMirrormaster+43 -2
VisualEditor: don't allow foldAllRefsDLynchmediawiki/extensions/CodeMirrormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

DLynch created this task.Sat, Aug 1, 5:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Aug 1, 5:08 PM
DLynch added a comment.Sat, Aug 1, 5:10 PM

Surprisingly, doesn't seem to be related to my recent 2017 editor preference changes. Rather, 52f5a4c9, which introduced the foldAllRefs preference, didn't make it respect the underlying codeFolding preference that was already disabled in the VE integration.

gerritbot added a comment.Sat, Aug 1, 5:11 PM

Change #1319918 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/CodeMirror@master] VisualEditor: don't allow foldAllRefs

https://gerrit.wikimedia.org/r/1319918

gerritbot added a project: Patch-For-Review.Sat, Aug 1, 5:11 PM
DLynch added a comment.Sat, Aug 1, 5:17 PM

Actually, sort of related to 5ffc6ff024bc539bfa4170eb16d967e332975e32 which introduced the preferences panel to the 2017 integration. Before that there was no way for a foldAllRefs: true to make its way to the 2017 editor, so it not being affected by codeFolding had no way to actually show up.

DLynch moved this task from Incoming to Code review on the Editing-team (FY2026-27 Q1 sprint 2) board.Sat, Aug 1, 5:18 PM
DLynch added a project: Editing-team (FY2026-27 Q1 sprint 2).
gerritbot added a comment.Sat, Aug 1, 5:41 PM

Change #1319919 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/CodeMirror@master] Preferences: honour the VE allowlist for callback preferences

https://gerrit.wikimedia.org/r/1319919

Hakimi97 subscribed.Sun, Aug 2, 12:55 AM
gerritbot added a comment.Mon, Aug 3, 4:31 PM

Change #1319918 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] VisualEditor: don't allow foldAllRefs

https://gerrit.wikimedia.org/r/1319918

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.14; 2026-08-04).Mon, Aug 3, 5:00 PM
DLynch moved this task from Code review to QA on the Editing-team (FY2026-27 Q1 sprint 2) board.Mon, Aug 3, 6:55 PM
DLynch added a project: Editing QA.
MusikAnimal moved this task from Backlog to Bugs on the MediaWiki-extensions-CodeMirror board.Thu, Aug 6, 8:46 PM
EAkinloose edited projects, added: Verified; removed: Editing QA.Thu, Aug 6, 11:11 PM
EAkinloose moved this task from QA to Ready for Sign off on the Editing-team (FY2026-27 Q1 sprint 2) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits