In dark mode, Kartographer maps are not opaque and pushpin markers have white instead of non-transparent background colors
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	RolandUnger
	Sat, Aug 1, 5:02 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

RolandUnger

Description

Steps to replicate the issue (include links if applicable):

Chose a page with a Kartographer map, for instance https://de.wikivoyage.org/wiki/Edersee
Alternately select light and dark mode

What happens?:

The bug occurs since yesterday and currently on Wikivoyage wikis
In light mode maps are Ok
In dark mode the maps are not opaque, and the pushpin markers have a white/gray background color

What should have happened instead?:

Maps in light and dark mode should look the same.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

It seems to be a stylesheet problem (opaque, brightness).

<img src="https://maps.wikimedia.org/v4/marker/pin-m-1+228B22@2x.png" class="leaflet-marker-icon leaflet-zoom-animated">

html.skin-theme-clientpref-night section > figure[typeof^="mw:File"]:not(.skin-invert-image) img {
      background-color: var(--background-color-base-fixed,#fff);
      color: var(--color-base-fixed,#202122);
      filter: brightness(0.8);
}

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Thumbnail: Restore dark-mode opt-out for static map tiles	TheDJ	mediawiki/extensions/Kartographer	master	+12 -0

Customize query in gerrit

Event Timeline

RolandUnger created this task.Sat, Aug 1, 5:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Aug 1, 5:02 AM

Change title to "... pushpin markers have white instead of transparent background colors"

The problem does not occur for full-screen maps.

Maybe these rules can help

@media screen {
	html.skin-theme-clientpref-night section > figure.mw-kartographer-container img {
		background-color: transparent !important;
		color: inherit !important;
		filter: none !important;
	}
}
@media screen and (prefers-color-scheme: dark) {
	html.skin-theme-clientpref-os section > figure.mw-kartographer-container img {
		background-color: transparent !important;
		color: inherit !important;
		filter: none !important;
	}
}

Change #1319930 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/Kartographer@master] Thumbnail: Restore dark-mode opt-out for static map tiles

https://gerrit.wikimedia.org/r/1319930

gerritbot added a project: Patch-For-Review.Sat, Aug 1, 9:08 PM

Aklapper added a project: Regression.Mon, Aug 3, 11:27 AM

Change #1319930 merged by jenkins-bot: