Fix various deficiencies of mw.util.addPortlet
Open, In Progress, Needs TriagePublic

Description

The mw.util.addPortlet method has room for improvement:

  • The portlet label is done with <label>, which is meant to be used within HTML forms only and is invalid for this case. Should be a <div>, probably with a class like mw-portlet-label.
  • The <div> list wrapper should also have a class, to make targeting it with CSS easier: mw-portlet-body.
  • There should be a check for the system message tooltip-[id], where [id] is the portlet ID, and if there is such a system message, it should be included as the portlet's title, as is done by Vector 2022.

Event Timeline

Change #1313863 had a related patch set uploaded (by Mr. Starfleet Command; author: Mr. Starfleet Command):

[mediawiki/core@master] [WIP] mw.util.addPortlet: Use a div for portlet label

https://gerrit.wikimedia.org/r/1313863

Change #1313871 had a related patch set uploaded (by Mr. Starfleet Command; author: Mr. Starfleet Command):

[mediawiki/skins/Vector@master] [WIP] Update Vector portlet code per changes to mw.util.addPortlet()

https://gerrit.wikimedia.org/r/1313871

Note to self: look at T342814 for more things that will need fixing.

Change #1313998 had a related patch set uploaded (by Mr. Starfleet Command; author: Mr. Starfleet Command):

[mediawiki/skins/MonoBook@master] [WIP] monobook: Updates related to mw.util.addPortlet

https://gerrit.wikimedia.org/r/1313998

Change #1314023 had a related patch set uploaded (by Mr. Starfleet Command; author: Mr. Starfleet Command):

[mediawiki/core@master] [WIP] mw.util.addPortlet: Use a div for portlet label

https://gerrit.wikimedia.org/r/1314023

Change #1314027 had a related patch set uploaded (by Mr. Starfleet Command; author: Mr. Starfleet Command):

[mediawiki/core@master] [WIP] mw.util.addPortlet: Use a div for portlet label

https://gerrit.wikimedia.org/r/1314027

Change #1314023 abandoned by Mr. Starfleet Command:

[mediawiki/core@master] [WIP] mw.util.addPortlet: Use a div for portlet label

Reason:

Superseded by I85c86153f946c9a266f84f5dcb1c25b9593e4c65

https://gerrit.wikimedia.org/r/1314023

Change #1314070 had a related patch set uploaded (by Mr. Starfleet Command; author: Mr. Starfleet Command):

[mediawiki/skins/Timeless@master] [WIP] Updates related to mw.util.addPortlet()

https://gerrit.wikimedia.org/r/1314070

Change #1314089 had a related patch set uploaded (by Mr. Starfleet Command; author: Mr. Starfleet Command):

[mediawiki/skins/Modern@master] [WIP] Updates related to mw.util.addPortlet()

https://gerrit.wikimedia.org/r/1314089

Change #1314090 had a related patch set uploaded (by Mr. Starfleet Command; author: Mr. Starfleet Command):

[mediawiki/skins/CologneBlue@master] [WIP] Updates related to mw.util.addPortlet()

https://gerrit.wikimedia.org/r/1314090

Mr._Starfleet_Command changed the task status from Open to In Progress.Jul 24 2026, 6:30 PM

Change #1314027 merged by jenkins-bot:

[mediawiki/core@master] mw.util.addPortlet: Refactor to accept a config object

https://gerrit.wikimedia.org/r/1314027