backfilLocalAccounts.php should ignore warnings
Closed, ResolvedPublic

Description

AuthManager::autoCreateAccount() will return a successful status with a warning if the account already exists. backfilLocalAccounts.php checks the status with isGood() and treats this as an error. It should treat it as a success since there's nothing left to backfill.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I'd like to take this one, unless someone is already on it.

Zabe renamed this task from backfilLocalAccounts.php shoudl ignore warnings to backfilLocalAccounts.php should ignore warnings.Sun, Jul 26, 9:48 AM

Change #1317601 had a related patch set uploaded (by Rajveer42; author: Rajveer42):

[mediawiki/extensions/CentralAuth@master] backfillLocalAccounts: do not treat warnings as errors

https://gerrit.wikimedia.org/r/1317601

Change #1317601 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] backfillLocalAccounts: do not treat warnings as errors

https://gerrit.wikimedia.org/r/1317601