Last selected web font for content language is applied when ULS display settings is opened, even when font loading is disabled
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  1. Open ULS display settings
  2. Open fonts tabs, enable fonts, choose non-system font for content language
  3. Save and reload
  4. Open ULS display settings
  5. Open fonts tabs, disable font loading
  6. Save and reload
  7. Open ULS display settings

What happens?:
Web font for the content language is applied.

What should have happened instead?:
No change for font anywhere.

Event Timeline

Initially I thought this could be caused by rEULSe17f5c0b393f: Merge jquery.webfonts into ext.uls.webfonts.repository, but reverting that change did not change behavior, so this is an older issue.

Change #1318192 had a related patch set uploaded (by Siebrand; author: Siebrand):

[mediawiki/extensions/UniversalLanguageSelector@master] displaysettings: Fix isWebFontsEnabled missing () in setupWebFonts

https://gerrit.wikimedia.org/r/1318192

Change #1318192 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] displaysettings: Fix isWebFontsEnabled missing () in setupWebFonts

https://gerrit.wikimedia.org/r/1318192

siebrand claimed this task.