Create Task
Maniphest T208966

TitlesMultiSelectWidget sometimes styles as invalid when all tags are valid
Closed, ResolvedPublic
Actions

Description

On adding a tag from the input, the widget toggles invalid if there is text in the input, whether the tag was valid or invalid.

This is a regression since T208507 and comes from OO.ui.MenuTagMultiselectWidget clearing the input too late. (OO.ui.TagMultiselectWidget behaves correctly.)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update OOUI to v0.29.5mediawiki/coremaster+63 -63
MenuTagMultiselectWidget: clear input if adding valid tagoojs/uimaster+15 -20
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Nov 7 2018, 5:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2018, 5:43 PM
Tchanders moved this task from Ready to In progress on the Anti-Harassment-Team (AHT Sprint 32) board.Nov 7 2018, 5:44 PM
gerritbot subscribed.Nov 7 2018, 6:33 PM

Change 472226 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] OO.ui.MenuTagMultiselectWidget: clear input if adding valid tag

https://gerrit.wikimedia.org/r/472226

gerritbot added a project: Patch-For-Review.Nov 7 2018, 6:33 PM
Tchanders moved this task from In progress to Review on the Anti-Harassment-Team (AHT Sprint 32) board.Nov 8 2018, 1:02 PM
• TBolliger moved this task from AHT Sprint 32 to AHT Sprint 33 on the Anti-Harassment-Team board.Nov 8 2018, 8:02 PM
• TBolliger edited projects, added Anti-Harassment-Team (AHT Sprint 33); removed Anti-Harassment-Team (AHT Sprint 32).
• TBolliger moved this task from Ready to Review on the Anti-Harassment-Team (AHT Sprint 33) board.Nov 8 2018, 8:04 PM
gerritbot added a comment.Nov 8 2018, 8:17 PM

Change 472226 merged by jenkins-bot:
[oojs/ui@master] MenuTagMultiselectWidget: clear input if adding valid tag

https://gerrit.wikimedia.org/r/472226

gerritbot added a comment.Nov 8 2018, 10:43 PM

Change 472587 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.5

https://gerrit.wikimedia.org/r/472587

gerritbot added a comment.Nov 8 2018, 11:10 PM

Change 472587 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.5

https://gerrit.wikimedia.org/r/472587

Volker_E closed this task as Resolved.Nov 12 2018, 12:53 AM
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Backlog to OOUI-0.29.5 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.29.5); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
• TBolliger moved this task from Review to Done on the Anti-Harassment-Team (AHT Sprint 33) board.Nov 15 2018, 10:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits