Merge pull request #291 from unckleg/cs-fixes-intellij

Intellij scan fixes (Unused/Uncompatible/Undocumented stuff)

Author: michalbundyra

src/Controller/ControllerManager.php

@@ -42,7 +42,7 @@ class ControllerManager extends AbstractPluginManager
      * Injects an initializer for injecting controllers with an
      * event manager and plugin manager.
      *
-     * @param  ConfigInterface|ContainerInterface $container
+     * @param  ConfigInterface|ContainerInterface $configOrContainerInstance
      * @param  array $config
      */
     public function __construct($configOrContainerInstance, array $config = [])

src/Controller/LazyControllerAbstractFactory.php

@@ -146,7 +146,7 @@ public function canCreate(ContainerInterface $container, $requestedName)
     private function resolveParameter(ContainerInterface $container, $requestedName)
     {
         /**
-         * @param ReflectionClass $parameter
+         * @param ReflectionParameter $parameter
          * @return mixed
          * @throws ServiceNotFoundException If type-hinted parameter cannot be
          *   resolved to a service in the container.

src/Controller/PluginManager.php

@@ -87,7 +87,8 @@ class PluginManager extends AbstractPluginManager
      * as the first controller, the reference to the controller inside the
      * plugin is lost.
      *
-     * @param  string $name
+     * @param  string     $name
+     * @param  null|array $options Options to use when creating the instance.
      * @return DispatchableInterface
      */
     public function get($name, array $options = null)

src/DispatchListener.php

@@ -83,7 +83,6 @@ public function onDispatch(MvcEvent $e)
             ? $routeMatch->getParam('controller', 'not-found')
             : 'not-found';
         $application       = $e->getApplication();
-        $events            = $application->getEventManager();
         $controllerManager = $this->controllerManager;
 
 

src/MiddlewareListener.php

@@ -11,14 +11,11 @@
 use Interop\Http\ServerMiddleware\MiddlewareInterface;
 use Psr\Http\Message\ResponseInterface as PsrResponseInterface;
 use Psr\Http\Message\ResponseInterface;
-use Psr\Http\Message\ServerRequestInterface as PsrServerRequestInterface;
 use Zend\EventManager\AbstractListenerAggregate;
 use Zend\EventManager\EventManagerInterface;
 use Zend\Mvc\Exception\InvalidMiddlewareException;
-use Zend\Mvc\Exception\ReachedFinalHandlerException;
 use Zend\Mvc\Controller\MiddlewareController;
 use Zend\Psr7Bridge\Psr7Response;
-use Zend\Router\RouteMatch;
 use Zend\Stratigility\Delegate\CallableDelegateDecorator;
 use Zend\Stratigility\MiddlewarePipe;
 
@@ -28,6 +25,7 @@ class MiddlewareListener extends AbstractListenerAggregate
      * Attach listeners to an event manager
      *
      * @param  EventManagerInterface $events
+     * @param  int                   $priority
      * @return void
      */
     public function attach(EventManagerInterface $events, $priority = 1)

src/Service/ControllerManagerFactory.php

@@ -24,7 +24,7 @@ class ControllerManagerFactory implements FactoryInterface
      * if the controller implements a setPluginManager() method.
      *
      * @param  ContainerInterface $container
-     * @param  string $Name
+     * @param  string $name
      * @param  null|array $options
      * @return ControllerManager
      */

src/Service/ServiceListenerFactory.php

@@ -14,7 +14,6 @@
 use Zend\ServiceManager\Exception\ServiceNotCreatedException;
 use Zend\ServiceManager\Factory\FactoryInterface;
 use Zend\ServiceManager\Factory\InvokableFactory;
-use Zend\ServiceManager\ServiceLocatorInterface;
 
 class ServiceListenerFactory implements FactoryInterface
 {
@@ -112,7 +111,9 @@ class ServiceListenerFactory implements FactoryInterface
      * - interface: the name of the interface that modules can implement as string
      * - method: the name of the method that modules have to implement as string
      *
-     * @param  ServiceLocatorInterface  $serviceLocator
+     * @param  ContainerInterface  $container
+     * @param  string              $requestedName
+     * @param  null|array          $options
      * @return ServiceListenerInterface
      * @throws ServiceNotCreatedException for invalid ServiceListener service
      * @throws ServiceNotCreatedException For invalid configurations.

src/Service/ViewHelperManagerFactory.php

@@ -31,6 +31,8 @@ class ViewHelperManagerFactory extends AbstractPluginManagerFactory
      * Create and return the view helper manager
      *
      * @param  ContainerInterface $container
+     * @param  string             $requestedName
+     * @param  null|array         $options
      * @return HelperPluginManager
      * @throws ServiceNotCreatedException
      */

src/View/Http/DefaultRenderingStrategy.php

@@ -76,7 +76,7 @@ public function getLayoutTemplate()
      *
      * @param  MvcEvent $e
      * @return Response|null
-     * @throws \Exception
+     * @throws \Exception|\Throwable
      */
     public function render(MvcEvent $e)
     {

test/Application/BadControllerTrait.php

@@ -10,7 +10,6 @@
 use ReflectionProperty;
 use Zend\Http\PhpEnvironment\Request;
 use Zend\Http\PhpEnvironment\Response;
-use Zend\Mvc\Application;
 use Zend\Mvc\Controller\ControllerManager;
 use Zend\Mvc\Service\ServiceManagerConfig;
 use Zend\Mvc\Service\ServiceListenerFactory;

test/Application/InvalidControllerTypeTrait.php

@@ -11,7 +11,6 @@
 use stdClass;
 use Zend\Http\PhpEnvironment\Request;
 use Zend\Http\PhpEnvironment\Response;
-use Zend\Mvc\Application;
 use Zend\Mvc\Controller\ControllerManager;
 use Zend\Mvc\Service\ServiceManagerConfig;
 use Zend\Mvc\Service\ServiceListenerFactory;

test/Application/MissingControllerTrait.php

@@ -10,7 +10,6 @@
 use ReflectionProperty;
 use Zend\Http\PhpEnvironment\Request;
 use Zend\Http\PhpEnvironment\Response;
-use Zend\Mvc\Application;
 use Zend\Mvc\Service\ServiceManagerConfig;
 use Zend\Mvc\Service\ServiceListenerFactory;
 use Zend\Router;

test/Application/PathControllerTrait.php

@@ -10,7 +10,6 @@
 use ReflectionProperty;
 use Zend\Http\PhpEnvironment\Request;
 use Zend\Http\PhpEnvironment\Response;
-use Zend\Mvc\Application;
 use Zend\Mvc\Controller\ControllerManager;
 use Zend\Mvc\Service\ServiceManagerConfig;
 use Zend\Mvc\Service\ServiceListenerFactory;

test/ApplicationTest.php

@@ -165,6 +165,7 @@ public function testEventsAreEmptyAtFirst()
      * @param string $listenerServiceName
      * @param string $event
      * @param string $method
+     * @param bool   $isCustom
      *
      * @dataProvider bootstrapRegistersListenersProvider
      */

test/Controller/ActionControllerTest.php

@@ -8,7 +8,6 @@
 namespace ZendTest\Mvc\Controller;
 
 use PHPUnit\Framework\TestCase;
-use ReflectionClass;
 use Zend\EventManager\EventManager;
 use Zend\EventManager\SharedEventManager;
 use Zend\EventManager\SharedEventManagerInterface;
@@ -49,7 +48,7 @@ public function setUp()
     }
 
     /**
-     * @param SharedEventManager
+     * @param  SharedEventManagerInterface $sharedManager
      * @return EventManager
      */
     protected function createEventManager(SharedEventManagerInterface $sharedManager)

test/Controller/ControllerManagerTest.php

@@ -8,7 +8,6 @@
 namespace ZendTest\Mvc\Controller;
 
 use PHPUnit\Framework\TestCase;
-use ReflectionClass;
 use Zend\EventManager\EventManager;
 use Zend\EventManager\EventManagerInterface;
 use Zend\EventManager\SharedEventManager;

test/Controller/Plugin/AcceptableViewModelSelectorTest.php

@@ -9,7 +9,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Zend\Http\Header\Accept\FieldValuePart\AcceptFieldValuePart;
-use Zend\Mvc\Controller\Plugin\AcceptableViewModelSelector;
 use Zend\Http\Request;
 use Zend\Mvc\Exception\InvalidArgumentException;
 use Zend\Mvc\MvcEvent;

test/Controller/Plugin/ForwardTest.php

@@ -8,7 +8,6 @@
 namespace ZendTest\Mvc\Controller\Plugin;
 
 use PHPUnit\Framework\TestCase;
-use ReflectionClass;
 use stdClass;
 use Zend\EventManager\EventManager;
 use Zend\EventManager\SharedEventManager;
@@ -21,7 +20,6 @@
 use Zend\Mvc\Controller\Plugin\Forward as ForwardPlugin;
 use Zend\Mvc\Controller\PluginManager;
 use Zend\Mvc\Exception\DomainException;
-use Zend\Mvc\Exception\InvalidControllerException;
 use Zend\Mvc\MvcEvent;
 use Zend\Router\RouteMatch;
 use Zend\ServiceManager\Config;

test/Controller/RestfulControllerTest.php

@@ -8,7 +8,6 @@
 namespace ZendTest\Mvc\Controller;
 
 use PHPUnit\Framework\TestCase;
-use ReflectionClass;
 use ReflectionObject;
 use stdClass;
 use Zend\EventManager\EventManager;

test/Controller/TestAsset/ControllerLoaderAbstractFactory.php

@@ -9,7 +9,6 @@
 
 use Interop\Container\ContainerInterface;
 use Zend\ServiceManager\Factory\AbstractFactoryInterface;
-use Zend\ServiceManager\ServiceLocatorInterface;
 use ZendTest\Mvc\TestAsset\PathController;
 
 class ControllerLoaderAbstractFactory implements AbstractFactoryInterface

test/Service/ServiceListenerFactoryTest.php

@@ -8,8 +8,6 @@
 namespace ZendTest\Mvc\Service;
 
 use PHPUnit\Framework\TestCase;
-use ReflectionClass;
-use ReflectionProperty;
 use Zend\Mvc\Service\ServiceListenerFactory;
 use Zend\ServiceManager\ServiceManager;
 

test/Service/ServiceManagerConfigTest.php

@@ -8,12 +8,10 @@
 namespace ZendTest\Mvc\Service;
 
 use PHPUnit\Framework\TestCase;
-use ReflectionClass;
 use stdClass;
 use Zend\EventManager\EventManager;
 use Zend\EventManager\EventManagerAwareInterface;
 use Zend\EventManager\SharedEventManagerInterface;
-use Zend\Mvc\Controller\PluginManager;
 use Zend\Mvc\Service\ServiceManagerConfig;
 use Zend\ServiceManager\Factory\InvokableFactory;
 use Zend\ServiceManager\ServiceManager;

test/View/DefaultRendereringStrategyTest.php

@@ -8,7 +8,6 @@
 namespace ZendTest\Mvc\View;
 
 use PHPUnit\Framework\TestCase;
-use Zend\EventManager\Event;
 use Zend\EventManager\EventManager;
 use Zend\EventManager\SharedEventManager;
 use Zend\EventManager\Test\EventListenerIntrospectionTrait;