Check SSLv3 padding length #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that records received satisfy the constraint given in RFC 6101 section 5.2.3.2: padding_length: The length of the padding must be less than the cipher's block length and may be zero.
kazu-yamamoto
added a commit
to kazu-yamamoto/hs-tls
that referenced
this pull request
Dec 22, 2019
Collaborator
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to TLS, SSL requires the CBC padding to be minimal, i.e. the minimum number of bytes to get a multiple of the block size. This PR adds the verification and makes tlsfuzzer script
test-SSLv3-padding.pyall successful.