Skip to content

Implement web-monetization/payment pointer #6345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 21, 2020

Conversation

benhalpern
Copy link
Contributor

@benhalpern benhalpern commented Feb 27, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This is the first step in implementing web monetization.

Web monetization is a protocol which allows websites to accept micro-payments to any page with the payment pointer meta tag. It's not yet standard, but through Grant for the Web, there will be lots of experimentation with this and we're getting involved ourselves.

For anyone that does not have a payment-enabled browser (or browser extension for now), this is just a meta tag that doesn't do anything at all. For anyone that does have payments activated, they'll start streaming tiny amounts of payment into our wallet.

This is the first step just to experiment for the site, but if it's all technically straightforward, we'll soon be adding the ability for authors to plop their payment pointers onto their content to get paid directly with no intervention from us.

This is all lightweight experimentation from us. As you can see from the size of this PR, it's not a huge technical commitment on our part, but if the ecosystem takes off, it will be fun to see what we might do. We'll definitely be following projects like this.

For other live communities looking to implement a payment pointer, you'll first need to set up a wallet to receive payments. More information is available here. Get in touch with us if you're curious about how you might leverage this on your platform in the future.

@benhalpern benhalpern requested a review from a team as a code owner February 27, 2020 23:10
@benhalpern benhalpern requested review from Zhao-Andy and removed request for a team February 27, 2020 23:10
@mstruve
Copy link
Contributor

mstruve commented May 7, 2020

Hey @benhalpern, since this hasn't been active for a while and has a bunch of conflicts I am going to close this PR. Feel free to resolve them and reopen if you want to get it pushed through!

@mstruve mstruve closed this May 7, 2020
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label May 7, 2020
@rhymes rhymes deleted the ben/implement-payment-pointer branch May 8, 2020 10:14
@benhalpern benhalpern restored the ben/implement-payment-pointer branch May 21, 2020 13:08
@benhalpern benhalpern reopened this May 21, 2020
@benhalpern benhalpern changed the title WIP/POC implement web-monetization/payment pointer Implement web-monetization/payment pointer May 21, 2020
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe to try

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels May 21, 2020
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels May 21, 2020
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels May 21, 2020
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a typo for you :)

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels May 21, 2020
@benhalpern
Copy link
Contributor Author

Thanks @Zhao-Andy

@benhalpern benhalpern merged commit b51d561 into master May 21, 2020
@benhalpern benhalpern deleted the ben/implement-payment-pointer branch May 21, 2020 16:10
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels May 21, 2020
Comment on lines +10 to +15
<!-- Expermiental web monetization payment pointer for micropayments -->
<!-- It lets readers make micropayments to websites they visit. -->
<!-- This is step 1: Get live in production to test for platform-wide payment pointer. -->
<!-- Step 2: Allow authors to set their payment pointer so they can directly monetize their content based on visitors. -->
<!-- Step 3: Enable further functionality based on what we learn from this experimentation and how the ecosystem evolves. -->
<!-- Step 3: Enable further functionality based on what we learn from this experimentation and how the ecosystem evolves. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benhalpern
Shouldn't this be behind <%# %> instead of HTML comment so it's won't show up in our markup?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I found it helpful when I was inspecting to see what it would take to add monetization to my own website 🙃

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes PR: merged bot applied label for PR's that are merged and removed PR: merged bot applied label for PR's that are merged PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 4, 2020
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: merged bot applied label for PR's that are merged labels Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: reviewed-approved bot applied label for PR's where reviewer approves changes
6 participants