Skip to content

Add a bridge between WebView JavaScript and native Android code. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 21, 2019

Conversation

VarunBarad
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This commit adds a bridge between Android WebView and the native Android code so that we can call native Android methods from inside JavaScript when it is running inside WebView.

This will later allow for porting more features to native code while still using the web-view for everything else.

Related Tickets & Documents

Screenshots/Recordings (if there are UI changes)

[optional] What gif best describes this PR or how it makes you feel?

hybrid combo

This commit adds a bridge between Android WebView and the native Android
code so that we can call native Android methods from inside JavaScript
when it is running inside WebView.
sierisimo
sierisimo previously approved these changes Oct 14, 2019
@sduduzog
Copy link
Contributor

sduduzog commented Oct 17, 2019

This will open up so much room for versatility

sierisimo
sierisimo previously approved these changes Oct 17, 2019
@VarunBarad VarunBarad changed the title Add a bridge between WebView JavaScript and native Android code. WIP: Add a bridge between WebView JavaScript and native Android code. Oct 20, 2019
@VarunBarad VarunBarad changed the title WIP: Add a bridge between WebView JavaScript and native Android code. Add a bridge between WebView JavaScript and native Android code. Oct 21, 2019
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for initiating this @VarunBarad ! This is going to add some exciting features!

@VarunBarad
Copy link
Contributor Author

@maestromac It is saying that "Merging is blocked - The base branch restricts merging to authorized users."
Can you look into it? If not you then who else should I tag?

@VarunBarad
Copy link
Contributor Author

It might have blocked the merging because I pushed a commit to this branch after your approval. That commit was only for updating my fork's feature branch with the changes that were pushed on master here.

@maestromac
Copy link
Contributor

Sorry @VarunBarad , I should've mention that you don't need to worry about the out-of-date warning because your branch did work locally...but there was indeed an issue with master. I resolved it but I shouldn't have ignored it in first place 😅

@maestromac maestromac merged commit 5bc0dc6 into forem:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
close