Skip to content

Clear history when returning to home #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 26, 2019

Conversation

roberto-o-r
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Clear WebView's history when returning to home. This provides a clearer back navigation hierarchy.

Related Tickets & Documents

Fixes #35

[optional] What gif best describes this PR or how it makes you feel?

image

@maestromac
Copy link
Contributor

Thank you for this PR @robertoissc . Sorry to let this sit for a bit.

I've been giving it a whirl. It works flawlessly but I find the UX to be a bit confusing.
My use case is that I occasionally would jump back to the homepage then immediate want to go back to where I was. I think maybe we could take a different approach with this and not clear the entire history every time, or perhaps let this be a setting for our users.

I still would like to accept this PR. what if we disable the feature (ie. comment out this line) for now. What do you think?

@roberto-o-r
Copy link
Contributor Author

Hey @maestromac! Thanks for your feedback, I have commented out the line you pointed. :)
Please feel free to accept this PR if you would like to discuss the feature or close it if you prefer to keep the navigation working as it is.

Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
close