Skip to content

Detect Azure Linux properly#2989

Merged
daandemeyer merged 2 commits into
systemd:mainfrom
daandemeyer:azure
Aug 30, 2024
Merged

Detect Azure Linux properly#2989
daandemeyer merged 2 commits into
systemd:mainfrom
daandemeyer:azure

Conversation

@daandemeyer
Copy link
Copy Markdown
Contributor

Fixes #2988

@reubeno
Copy link
Copy Markdown
Contributor

reubeno commented Aug 29, 2024

Thanks for the quick turnaround! I tried your change and confirmed that it resolved the issue I was running into. I can now successfully run mkosi -t disk without any other custom conf and get an image.

(I can't yet do the same within my cloned copy of this repo, but that's because mkosi/resources/mkosi-tools/mkosi.conf.d/10-azure.conf references erofs-utils, which doesn't presently exist in Azure Linux. Removing that unblocks the latter. Should I file a separate issue/PR for that?)

@daandemeyer
Copy link
Copy Markdown
Contributor Author

@reubeno erofs-utils was there last week. Can you figure out why it was removed?

@reubeno
Copy link
Copy Markdown
Contributor

reubeno commented Aug 30, 2024

@daandemeyer microsoft/azurelinux#9971 added EROFS support in the Azure Linux 3.0 kernel, but I can't see any indication that the userspace tools (i.e., erofs-utils) were ever present.

With that said, they seem like they ought to be in the distro too now that kernel support has been enabled. FYI to @christopherco

@hsiangkao
Copy link
Copy Markdown

@daandemeyer microsoft/azurelinux#9971 added EROFS support in the Azure Linux 3.0 kernel, but I can't see any indication that the userspace tools (i.e., erofs-utils) were ever present.

With that said, they seem like they ought to be in the distro too now that kernel support has been enabled. FYI to @christopherco

JFYI: we're now at erofs-utils 1.8.1, yet recently there are some new hotfixes submited.
I think I will release erofs-utils 1.8.2 this weekend.

@daandemeyer
Copy link
Copy Markdown
Contributor Author

@daandemeyer microsoft/azurelinux#9971 added EROFS support in the Azure Linux 3.0 kernel, but I can't see any indication that the userspace tools (i.e., erofs-utils) were ever present.

With that said, they seem like they ought to be in the distro too now that kernel support has been enabled. FYI to @christopherco

It was actually a bug in mkosi uncovered by this fix, so it indeed never was available in azure linux.

@daandemeyer daandemeyer merged commit c7b9792 into systemd:main Aug 30, 2024
@daandemeyer daandemeyer deleted the azure branch August 30, 2024 08:59
@reubeno
Copy link
Copy Markdown
Contributor

reubeno commented Aug 30, 2024

Thanks for the quick turnaround and resolution! I really appreciate the effort you've put into supporting Azure Linux.

@hsiangkao
Copy link
Copy Markdown

@daandemeyer microsoft/azurelinux#9971 added EROFS support in the Azure Linux 3.0 kernel, but I can't see any indication that the userspace tools (i.e., erofs-utils) were ever present.
With that said, they seem like they ought to be in the distro too now that kernel support has been enabled. FYI to @christopherco

JFYI: we're now at erofs-utils 1.8.1, yet recently there are some new hotfixes submited. I think I will release erofs-utils 1.8.2 this weekend.

Hi @christopherco, in case that erofs-utils may be interesting, I've released erofs-utils 1.8.2 yesterday.
and the current use cases (maybe incomplete) are documented on the website too: https://erofs.docs.kernel.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants