Skip to content

feat(es/minifier): Optimize code generated by optional chaining #10292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

feat(es/minifier): Optimize code generated by optional chaining #10292

merged 2 commits into from
Mar 31, 2025

Conversation

Austaras
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):
@Austaras Austaras requested a review from a team as a code owner March 29, 2025 08:35
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a8356d4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 29, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10292 will degrade performances by 2.08%

Comparing Austaras:null (a8356d4) with main (7daf4f4)

Summary

❌ 1 regressions
✅ 151 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ serialization of serde 2.8 µs 2.8 µs -2.08%
@kdy1 kdy1 self-assigned this Mar 30, 2025
@kdy1 kdy1 added this to the Planned milestone Mar 30, 2025
kdy1
kdy1 reviewed Mar 30, 2025
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good in general, but I think this would be more readable
@kdy1 kdy1 changed the title feat(es/minifier): Optimize optional generated code feat(es/minifier): Optimize code generated by optional chaining Mar 30, 2025
@Austaras
Copy link
Member Author

Yeah I would also like to give it a better name.
@kdy1
Copy link
Member

kdy1 commented Mar 30, 2025

Sounds good. Can you rename it within this PR?
@kdy1 kdy1 requested a review from a team as a code owner March 30, 2025 10:00
kdy1
kdy1 previously approved these changes Mar 30, 2025
View reviewed changes
@kdy1
Copy link
Member

kdy1 commented Mar 30, 2025

Do you want to rename the function in this PR? I'm fine with either of the options of creating another PR or modifying within this PR
@Austaras
Copy link
Member Author

Do you want to rename the function in this PR? I'm fine with either of the options of creating another PR or modifying within this PR

I've renamed it.
@kdy1
Copy link
Member

kdy1 commented Mar 30, 2025

I think you made a mistake? Maybe it is a bug of Github, but to be sure. (It's not showing on the diff view)
@Austaras
Copy link
Member Author

Sorry I pushed wrong commit.
@Austaras Austaras requested a review from kdy1 March 30, 2025 11:04
kdy1
kdy1 previously approved these changes Mar 31, 2025
View reviewed changes
@kdy1 kdy1 merged commit 0d88041 into swc-project:main Mar 31, 2025
18 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.11.14 Mar 31, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants
@Austaras @kdy1