🐛 fix(activation): silence deactivate hash -r under set -e#3152
Merged
Conversation
The deactivate() hash -r call lacked the || true guard the trailing activation call already had, so deactivate could abort under set -euo pipefail with shell hashing disabled. Matches CPython venv gh-149701.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcing the bash/zsh activation script and later running
deactivatecould abort the shell when strict mode is on. 🐚 Underset -euo pipefailwith shell command hashing disabled (set +h), thehash -rcall insidedeactivate()returns non-zero, and2>/dev/nullonly hides its stderr, not its exit status, so the failing command tears down the session.The
deactivate()call now appends|| true, the same guard the trailing activation-timehash -ralready carried. This brings the twohash -rsites into line and mirrors the equivalent CPythonvenvchange in gh-149701.The fix is confined to the bash/zsh activator; behavior under non-strict shells is unchanged since
hash -ralready succeeded there.