Skip to content

ENH: Add StringMethods.zfill #9387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2015
Merged

ENH: Add StringMethods.zfill #9387

merged 1 commit into from
Feb 4, 2015

Conversation

@sinhrks
Copy link
Member

@sinhrks sinhrks commented Feb 1, 2015

Derived from #9111. Fixed docstring of str_pad which is inprecise.
@sinhrks sinhrks mentioned this pull request Feb 1, 2015
Closed
24 tasks
shoyer
shoyer reviewed Feb 1, 2015
View reviewed changes
pandas/core/strings.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be "filled with 0", not fillchar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. Fixed.
@jreback jreback added Strings String extension data type and string data API Design labels Feb 2, 2015
@jreback jreback added this to the 0.16.0 milestone Feb 2, 2015
@shoyer
Copy link
Member

shoyer commented Feb 2, 2015

This looks good to me...
TomAugspurger pushed a commit that referenced this pull request Feb 4, 2015
Merge pull request #9387 from sinhrks/string_zfill
dc6592e 
ENH: Add StringMethods.zfill
@TomAugspurger TomAugspurger merged commit dc6592e into pandas-dev:master Feb 4, 2015
@TomAugspurger
Copy link
Contributor

Thanks @sinhrks .
@sinhrks sinhrks deleted the string_zfill branch February 4, 2015 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Design Strings String extension data type and string data

4 participants

@sinhrks @shoyer @TomAugspurger @jreback