BUG: fix reading pre-0.14.1 pickles of containers with one block and dup items #7794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immerrr
changed the title
immerrr
changed the title
Contributor
|
just put up some legacy files whatever your python / platform (if u want to multiple versions of oython that's ok) it doesn't matter much that we have for every platform for very version cross compat is pretty much there |
Contributor
Author
|
Ok, I've added pickles for 0.13.0, 0.14.0 (just in case) and 0.14.1. |
Contributor
|
perfect! ping when green |
Contributor
|
you have to add the directory of 0.14.0 to (actually prob is a better way to do by adding all directories under data), any idea? |
Contributor
|
@immerrr pls rebase another commit added the 0.14.0 pickle dir already |
Don't generate them for pre-0.14.1 as they cannot be unpickled.
Series, frames and panels that contain only one block can be unpickled under the assumption that block items correspond to manager items 1-to-1.
Contributor
Author
|
rebased and green |
jreback
added a commit
that referenced
this pull request
Jul 21, 2014
…unique-index BUG: fix reading pre-0.14.1 pickles of containers with one block and dup items
Contributor
|
@immerrr thanks for the fix! preserving pickle compat is never easy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series, frames and panels that contain only one block can be unpickled
under the assumption that block items correspond to manager items 1-to-1
(as pointed out in #7329).
I still don't have any of darwin/win/32bit platforms at hand, so I
cannot post those pickles. Also, my linux has a fresher python than
indicated by filenames of existing pickle test data. I did generate
some data to test the fix, the question is do you want me to upload it?