API/DEPR: Deprecate order kwarg in factorize #6930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make sure to add to #6581 |
1 task
TomAugspurger
pushed a commit
that referenced
this pull request
Apr 22, 2014
API/DEPR: Deprecate order kwarg in factorize
jreback
added a commit
to jreback/pandas
that referenced
this pull request
Feb 10, 2016
TomAugspurger
pushed a commit
that referenced
this pull request
Feb 10, 2016
xref #6930 Author: Jeff Reback <[email protected]> Closes #12274 from jreback/order and squashes the following commits: 7584397 [Jeff Reback] DEPR: remove order kw from .factorize(), xref #6930
cldy
pushed a commit
to cldy/pandas
that referenced
this pull request
Feb 11, 2016
xref pandas-dev#6930 Author: Jeff Reback <[email protected]> Closes pandas-dev#12274 from jreback/order and squashes the following commits: 7584397 [Jeff Reback] DEPR: remove order kw from .factorize(), xref pandas-dev#6930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6926
orderwasn't being used at all.I couldn't use the deprecate_kwarg decorator since the kwarg is being removed, not changed.