Handle masked arrays in DataFrame constructor #396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great-- thanks for making sure it's well-tested |
|
I'll make an issue to investigate handling of other dtypes. like int or boolean maskedarrays will need special handling. not that important at the moment |
dan-nadler
pushed a commit
to dan-nadler/pandas
that referenced
this pull request
Sep 23, 2019
Feature: as_of argument to MetadataStore.read
dan-nadler
pushed a commit
to dan-nadler/pandas
that referenced
this pull request
Sep 23, 2019
Add changelog to PR pandas-dev#396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If passing a masked array to DataFrame constructor, my expectation was that the masked entries would end up as NAN's in the DataFrame. This does not appear to be the case. The commits in the pull request try toe address that.
as always, comments welcome.
thanks