Skip to content

ENH: PeriodIndex now accepts pd.NaT #13430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ENH: PeriodIndex now accepts pd.NaT #13430

wants to merge 1 commit into from

Conversation

@sinhrks
Copy link
Member

@sinhrks sinhrks commented Jun 12, 2016 •
edited
Loading

  • tests added / passed
  • passes git diff upstream/master | flake8 --diff
  • whatsnew entry

Related to #12759. PeirodIndex can be created from list/array which contains pd.NaT.

currently it raises:

pd.PeriodIndex([pd.NaT])
# ValueError: freq not specified and cannot be inferred from first element

pd.PeriodIndex([pd.Period('2011-01', freq='M'), pd.NaT])
# AttributeError: 'NaTType' object has no attribute 'ordinal'
@sinhrks sinhrks added API Design Period Period data type labels Jun 12, 2016
@sinhrks sinhrks added this to the 0.18.2 milestone Jun 12, 2016
@sinhrks sinhrks mentioned this pull request Jun 12, 2016
Closed
6 tasks
@codecov-io
Copy link

codecov-io commented Jun 12, 2016 •
edited
Loading

Current coverage is 84.25%

Merging #13430 into master will increase coverage by <.01%

@@             master     #13430   diff @@
==========================================
  Files           138        138          
  Lines         50810      50805     -5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42809      42805     -4   
+ Misses         8001       8000     -1   
  Partials          0          0

Powered by Codecov. Last updated by 07761c5...5990de6
jreback
jreback reviewed Jun 12, 2016
View reviewed changes
pandas/src/period.pyx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these only integers at this point? e.g. we normally use a very generic check for NaT, is_null_datetimelike
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is possible to be called with both int64 and object types so for sure need to check all cases here
@jreback
Copy link
Contributor

jreback commented Jun 14, 2016

lgtm. ping on green.
@jreback jreback closed this in 112685f Jun 14, 2016
@jreback
Copy link
Contributor

jreback commented Jun 14, 2016

ty sir!
@sinhrks sinhrks deleted the period_nat branch June 14, 2016 22:35
@sinhrks sinhrks mentioned this pull request Jul 10, 2016
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Design Period Period data type

3 participants

@sinhrks @codecov-io @jreback