Skip to content

BUG: Fix to_dict() problem when using datetime DataFrame #11247 #11327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BUG: Fix to_dict() problem when using datetime DataFrame #11247 #11327

wants to merge 1 commit into from

Conversation

@ethanluoyc
Copy link
Contributor

closes #11247

This is my first time contributing through PR so forgive me if I make any silly mistake.
The issue can be referred to in GH11247
I followed @jreback 's suggestion to box things up in to_dict() but I am not sure if this is what he means because I do not know exactly when _maybe_datetime() should be used. Initially I tried to tweak internals.py but it fails.

Let me know how I can improve from here. Hope I can really learn from my first PR.
@jreback
Copy link
Contributor

jreback commented Oct 14, 2015

see guidelines here: http://pandas.pydata.org/pandas-docs/stable/contributing.html

dont' turn on PEP changes for your editor.
@ethanluoyc
Copy link
Contributor Author

I think I forgot to fetch to update my local master before my first commit to this PR. Somehow I messed up is it true?
@jreback
Copy link
Contributor

jreback commented Oct 14, 2015

add tests! (ideally for each one of the orients if we dont' have already).
@jreback jreback added Bug Output-Formatting __repr__ of pandas objects, to_string Dtype Conversions Unexpected or buggy dtype conversions labels Oct 14, 2015
@ethanluoyc
Copy link
Contributor Author

which test case shall I add in? I am new to this :)

On 15 Oct 2015, at 2:50 AM, Jeff Reback [email protected] wrote:

add tests! (ideally for each one of the orients if we dont' have already).

—
Reply to this email directly or view it on GitHub #11327 (comment).
@ethanluoyc
Copy link
Contributor Author

@jreback I have added tests:)
jreback
jreback reviewed Oct 15, 2015
View reviewed changes
pandas/tests/test_frame.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this a mixed frame ,e.g. add a float and a string say. obviously need to adjust the tests as well.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted the tests and now it tests both mixed and single dtypes
@jreback
Copy link
Contributor

jreback commented Oct 15, 2015

pls add a whatsnew note for 0.17.1 in bug fixes
@jreback jreback added this to the 0.17.1 milestone Oct 15, 2015
@ethanluoyc
Copy link
Contributor Author

Just asking what I should do if I merge updates locally with my branch and need to merge the 2 commits into one..

—
Sent from Mailbox

On Fri, Oct 16, 2015 at 6:25 AM, Jeff Reback [email protected]
wrote:

pls add a whatsnew note for 0.17.1 in bug fixes

Reply to this email directly or view it on GitHub:
#11327 (comment)
@ethanluoyc
BUG: Fix to_dict() problem when using only datetime pandas-dev#11247
938b076 
Fix a bug where to_dict() does not return Timestamp when there is only
datetime dtype present.
@jreback
Copy link
Contributor

jreback commented Oct 16, 2015

merged via 89b4e5b

thanks!
@jreback jreback closed this Oct 16, 2015
@jreback jreback mentioned this pull request Oct 16, 2015
Closed
@ethanluoyc ethanluoyc deleted the record-fix branch October 17, 2015 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Dtype Conversions Unexpected or buggy dtype conversions Output-Formatting __repr__ of pandas objects, to_string

2 participants

@ethanluoyc @jreback