Skip to content

DDT: Switch to using wmsums for lookup stats#17980

Merged
behlendorf merged 1 commit into
openzfs:masterfrom
amotin:dedup_wmsum
Dec 1, 2025
Merged

DDT: Switch to using wmsums for lookup stats#17980
behlendorf merged 1 commit into
openzfs:masterfrom
amotin:dedup_wmsum

Conversation

@amotin
Copy link
Copy Markdown
Member

@amotin amotin commented Nov 25, 2025

ddt_lookup() is a very busy code under a highly congested global lock. Anything we can save here is very important.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:
@amotin
DDT: Switch to using wmsums for lookup stats
1bf553f 
ddt_lookup() is a very busy code under a highly congested global
lock.  Anything we can save here is very important.

Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
robn
robn approved these changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@robn robn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nice.

(also you reminded me that I have a patch lying around here somewhere to help generate this stat boilerplate; must find it and polish it up sometime)
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Nov 26, 2025
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 1, 2025
@behlendorf behlendorf merged commit a5b665d into openzfs:master Dec 1, 2025
33 of 42 checks passed
@amotin amotin deleted the dedup_wmsum branch December 1, 2025 18:45
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Dec 10, 2025
@amotin @behlendorf
DDT: Switch to using wmsums for lookup stats
7d7729e 
ddt_lookup() is a very busy code under a highly congested global
lock.  Anything we can save here is very important.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17980
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Dec 10, 2025
@amotin @behlendorf
DDT: Switch to using wmsums for lookup stats
a785ddc 
ddt_lookup() is a very busy code under a highly congested global
lock.  Anything we can save here is very important.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17980
kithrup pushed a commit to KlaraSystems/zfs that referenced this pull request Dec 17, 2025
@amotin @kithrup
DDT: Switch to using wmsums for lookup stats
93df72e 
ddt_lookup() is a very busy code under a highly congested global
lock.  Anything we can save here is very important.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17980
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Feb 5, 2026
@amotin @lundman
DDT: Switch to using wmsums for lookup stats
925f116 
ddt_lookup() is a very busy code under a highly congested global
lock.  Anything we can save here is very important.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17980
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@amotin @lundman
DDT: Switch to using wmsums for lookup stats
45936b4 
ddt_lookup() is a very busy code under a highly congested global
lock.  Anything we can save here is very important.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17980
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@amotin @lundman
DDT: Switch to using wmsums for lookup stats
2350c36 
ddt_lookup() is a very busy code under a highly congested global
lock.  Anything we can save here is very important.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

3 participants

@amotin @robn @behlendorf