Skip to content

Suppress some ashift warnings#17830

Merged
behlendorf merged 1 commit into
openzfs:masterfrom
amotin:ashift_warnings
Oct 13, 2025
Merged

Suppress some ashift warnings#17830
behlendorf merged 1 commit into
openzfs:masterfrom
amotin:ashift_warnings

Conversation

@amotin
Copy link
Copy Markdown
Member

@amotin amotin commented Oct 8, 2025 •
edited
Loading

Do not warn about vdev ashifts being smaller then physical ashifts in a pool status if the pool ashift property set and vdev ashift satisfies it (bigger or equal), since user explicitly requested this. The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't matter much, and we don't even report individual vdevs ashifts there.

How Has This Been Tested?

# zpool set ashift=0 optane
# zpool status
  pool: optane
 state: ONLINE
status: One or more devices are configured to use a non-native block size.
        Expect reduced performance.
action: Replace affected devices with devices that support the
        configured block size, or migrate data to a properly configured
        pool.
config:

        NAME            STATE     READ WRITE CKSUM
        optane          ONLINE       0     0     0
          mirror-0      ONLINE       0     0     0
            nvd0p1.nop  ONLINE       0     0     0  block size: 4096B configured, 16384B native
            nvd1p1.nop  ONLINE       0     0     0  block size: 4096B configured, 16384B native

errors: No known data errors
# zpool set ashift=12 optane
# zpool status
  pool: optane
 state: ONLINE
config:

        NAME            STATE     READ WRITE CKSUM
        optane          ONLINE       0     0     0
          mirror-0      ONLINE       0     0     0
            nvd0p1.nop  ONLINE       0     0     0  block size: 4096B configured, 16384B native
            nvd1p1.nop  ONLINE       0     0     0  block size: 4096B configured, 16384B native

errors: No known data errors

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:
@amotin
Suppress some ashift warnings
a963b4b 
Do not warn about vdev ashifts being smaller then physical ashifts
in a pool status if the pool ashift property set and vdev ashift
satisfies it (bigger or equal), since user explicitly requested
this.  The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't
matter much, and we don't even report individual vdevs ashifts
there.

Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Oct 8, 2025
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 13, 2025
@behlendorf behlendorf merged commit f427647 into openzfs:master Oct 13, 2025
21 of 25 checks passed
@amotin amotin deleted the ashift_warnings branch October 13, 2025 17:42
amotin added a commit to truenas/zfs that referenced this pull request Oct 13, 2025
@amotin
Suppress some ashift warnings
b12368c 
Do not warn about vdev ashifts being smaller then physical ashifts
in a pool status if the pool ashift property set and vdev ashift
satisfies it (bigger or equal), since user explicitly requested
this.  The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't
matter much, and we don't even report individual vdevs ashifts
there.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17830
amotin added a commit to truenas/zfs that referenced this pull request Oct 13, 2025
@amotin
Suppress some ashift warnings
0cc1f35 
Do not warn about vdev ashifts being smaller then physical ashifts
in a pool status if the pool ashift property set and vdev ashift
satisfies it (bigger or equal), since user explicitly requested
this.  The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't
matter much, and we don't even report individual vdevs ashifts
there.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17830
bugclerk pushed a commit to truenas/zfs that referenced this pull request Oct 14, 2025
@amotin @bugclerk
Suppress some ashift warnings
a743615 
Do not warn about vdev ashifts being smaller then physical ashifts
in a pool status if the pool ashift property set and vdev ashift
satisfies it (bigger or equal), since user explicitly requested
this.  The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't
matter much, and we don't even report individual vdevs ashifts
there.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17830
(cherry picked from commit 0cc1f35)
amotin added a commit to truenas/zfs that referenced this pull request Oct 15, 2025
@amotin
Suppress some ashift warnings
dfd76ce 
Do not warn about vdev ashifts being smaller then physical ashifts
in a pool status if the pool ashift property set and vdev ashift
satisfies it (bigger or equal), since user explicitly requested
this.  The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't
matter much, and we don't even report individual vdevs ashifts
there.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17830
(cherry picked from commit 0cc1f35)
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Oct 21, 2025
@amotin @tonyhutter
Suppress some ashift warnings
f0bff23 
Do not warn about vdev ashifts being smaller then physical ashifts
in a pool status if the pool ashift property set and vdev ashift
satisfies it (bigger or equal), since user explicitly requested
this.  The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't
matter much, and we don't even report individual vdevs ashifts
there.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17830
@amotin amotin mentioned this pull request Dec 18, 2025
Merged
8 tasks
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Dec 18, 2025
@amotin @behlendorf
Suppress some ashift warnings
095a5c5 
Do not warn about vdev ashifts being smaller then physical ashifts
in a pool status if the pool ashift property set and vdev ashift
satisfies it (bigger or equal), since user explicitly requested
this.  The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't
matter much, and we don't even report individual vdevs ashifts
there.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17830
behlendorf pushed a commit that referenced this pull request Dec 20, 2025
@amotin @behlendorf
Suppress some ashift warnings
08d34f2 
Do not warn about vdev ashifts being smaller then physical ashifts
in a pool status if the pool ashift property set and vdev ashift
satisfies it (bigger or equal), since user explicitly requested
this.  The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't
matter much, and we don't even report individual vdevs ashifts
there.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes #17830
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jan 30, 2026
@amotin @lundman
Suppress some ashift warnings
cf967c9 
Do not warn about vdev ashifts being smaller then physical ashifts
in a pool status if the pool ashift property set and vdev ashift
satisfies it (bigger or equal), since user explicitly requested
this.  The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't
matter much, and we don't even report individual vdevs ashifts
there.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17830
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@amotin @lundman
Suppress some ashift warnings
fae6969 
Do not warn about vdev ashifts being smaller then physical ashifts
in a pool status if the pool ashift property set and vdev ashift
satisfies it (bigger or equal), since user explicitly requested
this.  The ashift of individual vdevs are still reported.

Do not warn about vdev ashifts in zpool import, since it doesn't
matter much, and we don't even report individual vdevs ashifts
there.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#17830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

4 participants

@amotin @robn @behlendorf @allanjude