Skip to content

mcp: surface profile migration guidance under --profile#23890

Merged
jif-oai merged 4 commits into
mainfrom
jif/mcp-new-profile
May 22, 2026
Merged

mcp: surface profile migration guidance under --profile#23890
jif-oai merged 4 commits into
mainfrom
jif/mcp-new-profile

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 21, 2026 •
edited
Loading

Why

codex --profile <name> mcp ... should reach the same profile-v2 migration guard as runtime commands. Otherwise legacy [profiles.<name>] users see the generic command-scope rejection instead of the existing guidance to move settings into $CODEX_HOME/<name>.config.toml.

What

  • Allow codex mcp through the --profile subcommand gate.
  • Pass profile loader overrides into the MCP entry point only to validate profile-v2 migration when a profile is present.
  • Keep MCP add/remove/list/get/login/logout behavior otherwise unchanged; this does not add profile-scoped MCP server management.
  • Cover the legacy profile migration error for codex --profile work mcp list.

Testing

  • cargo test -p codex-cli
@jif-oai jif-oai requested a review from a team as a code owner May 21, 2026 16:27
@jif-oai jif-oai changed the title feat: codex mcp on new profile feat: support --profile for codex mcp May 21, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e26a35e253

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment thread codex-rs/core/src/config/mod.rs Outdated
Comment thread codex-rs/cli/src/mcp_cmd.rs Outdated
Comment thread codex-rs/cli/src/mcp_cmd.rs Outdated
@jif-oai jif-oai changed the title feat: support --profile for codex mcp mcp: surface profile migration guidance under --profile May 21, 2026
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 22, 2026

@codex review
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9f1e9811b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment thread codex-rs/cli/src/mcp_cmd.rs
@jif-oai jif-oai merged commit ed80e5f into main May 22, 2026
31 checks passed
@jif-oai jif-oai deleted the jif/mcp-new-profile branch May 22, 2026 08:40
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant

@jif-oai