Skip to content

Commit cff62e3

Browse files
committed
fs: ensure dir.read() does not throw synchronously
PR-URL: #58228 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 1f1fab6 commit cff62e3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/internal/fs/dir.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class Dir {
9494
}
9595

9696
read(callback) {
97-
return this.#readImpl(true, callback);
97+
return arguments.length === 0 ? this.#readPromisified() : this.#readImpl(true, callback);
9898
}
9999

100100
#readImpl(maybeSync, callback) {

test/parallel/test-fs-opendir.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ async function doAsyncIterBreakTest() {
161161
break;
162162
}
163163

164-
await assert.rejects(async () => dir.read(), dirclosedError);
164+
await assert.rejects(dir.read(), dirclosedError);
165165
}
166166
doAsyncIterBreakTest().then(common.mustCall());
167167

@@ -173,7 +173,7 @@ async function doAsyncIterReturnTest() {
173173
}
174174
})();
175175

176-
await assert.rejects(async () => dir.read(), dirclosedError);
176+
await assert.rejects(dir.read(), dirclosedError);
177177
}
178178
doAsyncIterReturnTest().then(common.mustCall());
179179

@@ -189,7 +189,7 @@ async function doAsyncIterThrowTest() {
189189
}
190190
}
191191

192-
await assert.rejects(async () => dir.read(), dirclosedError);
192+
await assert.rejects(dir.read(), dirclosedError);
193193
}
194194
doAsyncIterThrowTest().then(common.mustCall());
195195

0 commit comments

Comments
 (0)