Skip to content

Commit 6582b19

Browse files
joyeecheungaduh95
authored andcommitted
test: reduce flakiness in test-heapdump-http2
By the time the response event is emitted on the client's side, the file may have already been fully piped and the stream pipe may have been destroyed, so the test should not look for the stream pipe in the snapshot. PR-URL: #58148 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 1bd7a2e commit 6582b19

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

test/pummel/test-heapdump-http2.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,11 @@ server.listen(0, () => {
5656
],
5757
},
5858
], { loose: true });
59-
// `Node / StreamPipe` (C++) -> StreamPipe (JS)
60-
state.validateSnapshotNodes('Node / StreamPipe', [
61-
{
62-
children: [
63-
{ node_name: 'StreamPipe', edge_name: 'native_to_javascript' },
64-
],
65-
},
66-
]);
59+
60+
// We don't necessarily have Node / StreamPipe here because by the time the
61+
// response event is emitted, the file may have already been fully piped here
62+
// and the stream pipe may have been destroyed.
63+
6764
// `Node / Http2Session` (C++) -> Http2Session (JS)
6865
state.validateSnapshotNodes('Node / Http2Session', [
6966
{

0 commit comments

Comments
 (0)