Add .NET 10 tests (#575)

* Add .NET 10 tests

* Fix yml matrix

* Fix workflow

* Use variable

Author: zijchen

.github/workflows/pr-validation.yml

@@ -2,29 +2,38 @@ name: pr-validation
 
 on: pull_request
 
+env:
+  LATEST_DOTNET_VERSION: 10.x
+
 jobs:
   test:
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
         os: [windows-latest, ubuntu-latest, macos-latest]
-        targetFramework: [net8.0, net9.0]
+        targetFramework: [net8.0, net9.0, net10.0]
         include:
           - targetFramework: net8.0
             dotnetVersion: 8.x
           - targetFramework: net9.0
             dotnetVersion: 9.x
+          - targetFramework: net10.0
+            dotnetVersion: 10.x
     steps:
-    - uses: actions/checkout@v4
-    - uses: actions/setup-dotnet@v4  # Latest version is always required
+    - name: Checkout
+      uses: actions/checkout@v4
+    - name: Setup .NET ${{ env.LATEST_DOTNET_VERSION }}
+      uses: actions/setup-dotnet@v4  # Latest version is always required
       with:
-        dotnet-version: 9.x
+        dotnet-version: ${{ env.LATEST_DOTNET_VERSION }}
         dotnet-quality: preview
-    - uses: actions/setup-dotnet@v4
+    - name: Setup .NET ${{ matrix.dotnetVersion }}
+      if: ${{ matrix.dotnetVersion != env.LATEST_DOTNET_VERSION }}
+      uses: actions/setup-dotnet@v4
       with:
         dotnet-version: ${{ matrix.dotnetVersion }}
-        dotnet-quality: preview
+        dotnet-quality: ga
     - run: dotnet build DacFx.sln
     - run: dotnet pack DacFx.sln --no-build
     - run: dotnet test DacFx.sln --no-build -f ${{ matrix.targetFramework }}

src/Microsoft.Build.Sql/sdk/Sdk.targets

@@ -73,7 +73,7 @@
   <Target Name="CheckForDuplicateSqlItems" Condition="'$(NetCoreBuild)' == 'true'" BeforeTargets="_SetupSqlBuildInputs">
 
     <PropertyGroup>
-      <DefaultItemsMoreInformationLink>https://aka.ms/upgrade-sqlproject</DefaultItemsMoreInformationLink>
+      <DefaultItemsMoreInformationLink>https://aka.ms/upgrade-sqlproject#required-remove-build-items-included-by-default</DefaultItemsMoreInformationLink>
     </PropertyGroup>
 
     <CheckForDuplicateItems

test/Microsoft.Build.Sql.Tests/BuildTests.cs

@@ -324,6 +324,9 @@ public void VerifyBuildWithTransitiveProjectReferences()
         [TestCase("net8.0")]
 #if NET9_0_OR_GREATER
         [TestCase("net9.0")]
+#endif
+#if NET10_0_OR_GREATER
+        [TestCase("net10.0")]
 #endif
         // https://github.com/microsoft/DacFx/issues/330
         public void VerifyBuildWithDifferentTargetFrameworks(string targetFramework)

test/Microsoft.Build.Sql.Tests/Microsoft.Build.Sql.Tests.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <!-- Multi-targeting to test SDK on different .NET versions, requires all of the following SDKs to be installed. -->
     <!-- To build and test only one version, add -f to dotnet command. -->
-    <TargetFrameworks>net8.0;net9.0</TargetFrameworks>
+    <TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>
     <Nullable>enable</Nullable>
     <!-- Disable EOL target framework check since we're explicitly testing against older .NET versions. -->
     <CheckEolTargetFramework>false</CheckEolTargetFramework>