Skip to content

feat: add DigitalOcean, Moodle and Oracle icons#388

Merged
antonreshetov merged 2 commits into
massCodeIO:masterfrom
adpe:feat/folder-icons
Jul 18, 2023
Merged

feat: add DigitalOcean, Moodle and Oracle icons#388
antonreshetov merged 2 commits into
massCodeIO:masterfrom
adpe:feat/folder-icons

Conversation

@adpe

@adpe adpe commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Change which was discussed in #385

check at least one

  • Bugfix
  • Feature
  • Refactor
  • Other, please describe:

Validations

@antonreshetov

Copy link
Copy Markdown
Member

The files look unoptimized. Use svgo or other svg optimization utilities. Better yet, find a good collection of icons that follow svg best practices.

@antonreshetov

Copy link
Copy Markdown
Member

Big collection of icons https://icones.js.org/

@Faq

Faq commented Jul 5, 2023

Copy link
Copy Markdown
@antonreshetov

Copy link
Copy Markdown
Member

The icons should also be fitted into a square and have a margin. You can take any icon from https://github.com/massCodeIO/massCode/tree/master/src/renderer/assets/svg/icons as an example.

@adpe

adpe commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

Got it! Thank you very much. Updated and added also a new one.

@adpe adpe changed the title feat: add DigitalOcean and Oracle icons feat: add DigitalOcean, Moodle and Oracle icons Jul 7, 2023
@antonreshetov antonreshetov merged commit 864e2f6 into massCodeIO:master Jul 18, 2023
@adpe adpe deleted the feat/folder-icons branch July 19, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants