Skip to content

Disable ListFromCacheSnapshot in ci-kubernetes-network-kind-alpha-beta-features#34587

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
serathius:disable-list-from-cache
Mar 24, 2025
Merged

Disable ListFromCacheSnapshot in ci-kubernetes-network-kind-alpha-beta-features#34587
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
serathius:disable-list-from-cache

Conversation

@serathius
Copy link
Copy Markdown
Contributor

@serathius serathius commented Mar 24, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Mar 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from MrHohn and aojea March 24, 2025 09:47
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 24, 2025
env:
- name: FEATURE_GATES
value: '{"AllAlpha":true,"AllBeta":true,"EventedPLEG": false}'
value: '{"AllAlpha":true,"AllBeta":true,"EventedPLEG": false,"ListFromCacheSnapshot": false}'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want different cluster behaviors depending on which features are enabled, the goal of this jobs is to ensure our cluster behavior is consistent

/hold

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, this is going to be enabled in more jobs, I don't like the idea of start modifying all the jobs, can we think in a better solution before trying this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just disabling an alpha feature is better than changing conformance test during code freeze.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then please add a comment explaining this and a TODO , we should fix this in 1.34

Please also modify these jobs #34584 , I've realized we were not running these tests on release informing and we missed this

/hold cancel

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serathius disable the test, not the feature

Servers with support for API chunking should support continue listing from the last key if the original version has been compacted away, though the list is inconsistent 
Copy link
Copy Markdown
Member

@aojea aojea Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# ListFromCacheSnapshot does not implement the Conformance behavior defined in this test so it flakes
# Ref: https://issues.k8s.io/131011
- name: SKIP
  value: "Servers.with.support.for.API.chunking.should.support.continue.listing.from.the.last.key.if.the.original.version has.been.compacted.away"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 24, 2025
@serathius serathius force-pushed the disable-list-from-cache branch from 4d34d76 to 492aa52 Compare March 24, 2025 11:07
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2025
@serathius serathius force-pushed the disable-list-from-cache branch from 492aa52 to 86819b5 Compare March 24, 2025 11:09
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2025
Comment thread config/jobs/kubernetes/sig-testing/kubernetes-kind.yaml Outdated
@serathius serathius force-pushed the disable-list-from-cache branch from 86819b5 to 25577c1 Compare March 24, 2025 11:12
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2025
@serathius serathius force-pushed the disable-list-from-cache branch from 25577c1 to 0f884d4 Compare March 24, 2025 11:15
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2025
@serathius serathius force-pushed the disable-list-from-cache branch from 0f884d4 to c781944 Compare March 24, 2025 11:16
@aojea
Copy link
Copy Markdown
Member

aojea commented Mar 24, 2025

/lgtm
/approve

Thanks, I notice we have some inconsistencies in the regex but that is for later for me

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 245a3b2 into kubernetes:master Mar 24, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@serathius: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-network-kind.yaml using file config/jobs/kubernetes/sig-network/sig-network-kind.yaml
  • key kubernetes-kind.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind.yaml
Details

In response to this:

/assign @wojtek-t @aojea

Fixes kubernetes/kubernetes#131011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder
Copy link
Copy Markdown
Member

We need to make sure when we do this that we have a tracking issue and active discussion about driving resolution, we cannot leave permanently disabling conformance features, this is a risk for graduating features and defeats the purpose of ensuring that alpha/beta features do not break stable APIs / conformance by way of running these jobs.

kubernetes/kubernetes#131011 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

5 participants