Disable ListFromCacheSnapshot in ci-kubernetes-network-kind-alpha-beta-features#34587
Conversation
| env: | ||
| - name: FEATURE_GATES | ||
| value: '{"AllAlpha":true,"AllBeta":true,"EventedPLEG": false}' | ||
| value: '{"AllAlpha":true,"AllBeta":true,"EventedPLEG": false,"ListFromCacheSnapshot": false}' |
There was a problem hiding this comment.
we don't want different cluster behaviors depending on which features are enabled, the goal of this jobs is to ensure our cluster behavior is consistent
/hold
There was a problem hiding this comment.
also, this is going to be enabled in more jobs, I don't like the idea of start modifying all the jobs, can we think in a better solution before trying this?
There was a problem hiding this comment.
I think just disabling an alpha feature is better than changing conformance test during code freeze.
There was a problem hiding this comment.
then please add a comment explaining this and a TODO , we should fix this in 1.34
Please also modify these jobs #34584 , I've realized we were not running these tests on release informing and we missed this
/hold cancel
There was a problem hiding this comment.
@serathius disable the test, not the feature
Servers with support for API chunking should support continue listing from the last key if the original version has been compacted away, though the list is inconsistent
There was a problem hiding this comment.
# ListFromCacheSnapshot does not implement the Conformance behavior defined in this test so it flakes
# Ref: https://issues.k8s.io/131011
- name: SKIP
value: "Servers.with.support.for.API.chunking.should.support.continue.listing.from.the.last.key.if.the.original.version has.been.compacted.away"
4d34d76 to
492aa52
Compare
492aa52 to
86819b5
Compare
86819b5 to
25577c1
Compare
25577c1 to
0f884d4
Compare
0f884d4 to
c781944
Compare
|
/lgtm Thanks, I notice we have some inconsistencies in the regex but that is for later for me |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@serathius: Updated the
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
We need to make sure when we do this that we have a tracking issue and active discussion about driving resolution, we cannot leave permanently disabling conformance features, this is a risk for graduating features and defeats the purpose of ensuring that alpha/beta features do not break stable APIs / conformance by way of running these jobs. |
/assign @wojtek-t @aojea
Fixes kubernetes/kubernetes#131011