Skip to content

Pass storage.ListOptions to WaitUntilFreshAndList#130589

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
serathius:watchcache-opts
Mar 6, 2025
Merged

Pass storage.ListOptions to WaitUntilFreshAndList#130589
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
serathius:watchcache-opts

Conversation

@serathius
Copy link
Copy Markdown
Contributor

@serathius serathius commented Mar 5, 2025

/kind cleanup

NONE

/sig api-machinery
/triage accepted
/assign @wojtek-t
/cc @liggitt
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2025
@k8s-ci-robot k8s-ci-robot requested a review from liggitt March 5, 2025 13:24
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Mar 5, 2025
@serathius
Copy link
Copy Markdown
Contributor Author

serathius commented Mar 5, 2025

Followup from #130267 requested in #130423 (comment)
@serathius serathius mentioned this pull request Mar 5, 2025
Merged
wojtek-t
wojtek-t reviewed Mar 5, 2025
View reviewed changes
Comment thread staging/src/k8s.io/apiserver/pkg/storage/cacher/watch_cache_test.go
@serathius
Copy link
Copy Markdown
Contributor Author

serathius commented Mar 5, 2025

/retest
1 similar comment
@serathius
Copy link
Copy Markdown
Contributor Author

serathius commented Mar 5, 2025

/retest
@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Mar 6, 2025

/lgtm
/approve
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 6, 2025

LGTM label has been added.

DetailsGit tree hash: 87a8c0afe4ec19fc9852921ab9c06b45f1f768db
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit c30b1eb into kubernetes:master Mar 6, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 6, 2025
@serathius serathius mentioned this pull request Mar 6, 2025
Open
16 tasks
@serathius serathius mentioned this pull request Jan 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

3 participants

@serathius @wojtek-t @k8s-ci-robot