KEP-3721: Promote Envfiles to beta and improve env file syntax#5530
Merged
k8s-ci-robot merged 1 commit intoOct 15, 2025
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
kind/kep
HirazawaUi
force-pushed
the
improve-env-file-syntax
branch
from
a3333f3 to
6c2e444
Compare
Contributor
Author
HirazawaUi
commented
Sep 14, 2025
lmktfy
reviewed
Sep 17, 2025
thockin
reviewed
Sep 18, 2025
|
|
||
| **Parsing Rationale and POSIX Compliance:** | ||
|
|
||
| When parsing the variable's value, our interpreter will strictly emulate the behavior of a double-quoted variable expansion ("$VAR") in a POSIX-compliant shell. This design choice ensures that the provided value is treated as a literal string without any interpretation or modification. |
Member
There was a problem hiding this comment.
s/double/single/ -- we are NOT doing double-quoted interpolation
Contributor
Author
There was a problem hiding this comment.
I just wanted to clearly describe the mistake I made in kubernetes/kubernetes#133606 (comment). I’m concerned that others might make the same error. It seems my poor choice of words didn’t accurately convey what I intended to express. Let’s remove it and describe everything in a simpler way.
HirazawaUi
force-pushed
the
improve-env-file-syntax
branch
4 times, most recently
from
fb630f2 to
a9add28
Compare
Member
|
/assign @SergeyKanzhelev @soltysh |
10 tasks
HirazawaUi
changed the title
HirazawaUi
force-pushed
the
improve-env-file-syntax
branch
from
a9add28 to
5834a10
Compare
k8s-ci-robot
added
the
lgtm
soltysh
reviewed
Oct 9, 2025
Contributor
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
From PRR perspective only the testing (integration, e2e and upgrade-downgrade) sections are missing.
HirazawaUi
force-pushed
the
improve-env-file-syntax
branch
from
5834a10 to
22b2888
Compare
k8s-ci-robot
added
size/L
HirazawaUi
force-pushed
the
improve-env-file-syntax
branch
from
22b2888 to
fda1fe6
Compare
toVersus
reviewed
Oct 13, 2025
soltysh
approved these changes
Oct 15, 2025
Contributor
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
Minor nit, but not blocking. Please make sure to update this in a followup.
k8s-ci-robot
added
the
approved
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HirazawaUi, SergeyKanzhelev, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
HirazawaUi
force-pushed
the
improve-env-file-syntax
branch
from
fda1fe6 to
2e62f2a
Compare
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.