Skip to content

KEP-4427: Relaxed DNS search validation to beta#5045

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
adrianmoisey:4427-promote-to-beta
Feb 4, 2025
Merged

KEP-4427: Relaxed DNS search validation to beta#5045
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
adrianmoisey:4427-promote-to-beta

Conversation

@adrianmoisey
Copy link
Copy Markdown
Member

@adrianmoisey adrianmoisey commented Jan 16, 2025

  • One-line PR description: Updates sections for beta release targeting 1.33

  • Issue link: Relaxed DNS search string validation #4427

  • Other comments: This is my first time doing this. I think I covered everything, but forgive me if I missed something

/sig network
/assign aojea danwinship thockin

PRR reviewers:
/assign jpbetz
@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2025
danwinship
danwinship reviewed Jan 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@danwinship danwinship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Comment thread keps/sig-network/4427-relaxed-dns-search-validation/kep.yaml
- "@adrianmoisey"
owning-sig: sig-network
status: implementable
status: implemented
Copy link
Copy Markdown
Contributor

@danwinship danwinship Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i forget when you're supposed to change this, but I guess the PRR reviewer will complain if it's wrong 🙂
Copy link
Copy Markdown
Contributor

@jpbetz jpbetz Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always set this to implemented after the feature goes GA, but I'm happy to defer to @kubernetes/sig-release.

(I don't consider this field to be under PRR purview. we focus on the PRR section of the readme)
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2025
@jpbetz jpbetz mentioned this pull request Feb 4, 2025
Closed
12 tasks
@jpbetz
Copy link
Copy Markdown
Contributor

jpbetz commented Feb 4, 2025

/approve
For PRR
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey, danwinship, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit d254533 into kubernetes:master Feb 4, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

6 participants

@adrianmoisey @jpbetz @k8s-ci-robot @danwinship @thockin @aojea