Skip to content

Commit c6d2fb0

Browse files
authored
Merge pull request #409 from ttuegel/pull-request-reviews
Pull requests reviews API uses issue number
2 parents fdbe626 + ea74dcb commit c6d2fb0

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

spec/GitHub/PullRequestReviewsSpec.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
module GitHub.PullRequestReviewsSpec where
33

44
import qualified GitHub
5-
import GitHub.Data.Id (Id (Id))
5+
import GitHub.Data (IssueNumber (IssueNumber))
66

77
import Prelude ()
88
import Prelude.Compat
@@ -29,4 +29,4 @@ spec = do
2929
cs `shouldSatisfy` isRight
3030
where
3131
prs =
32-
[("phadej", "github", Id 268)]
32+
[("phadej", "github", IssueNumber 268)]

src/GitHub/Endpoints/PullRequests/Reviews.hs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import Prelude ()
2929
pullRequestReviewsR
3030
:: Name Owner
3131
-> Name Repo
32-
-> Id PullRequest
32+
-> IssueNumber
3333
-> FetchCount
3434
-> Request k (Vector Review)
3535
pullRequestReviewsR owner repo prid =
@@ -50,7 +50,7 @@ pullRequestReviewsR owner repo prid =
5050
pullRequestReviews
5151
:: Name Owner
5252
-> Name Repo
53-
-> Id PullRequest
53+
-> IssueNumber
5454
-> IO (Either Error (Vector Review))
5555
pullRequestReviews owner repo prid =
5656
executeRequest' $ pullRequestReviewsR owner repo prid FetchAll
@@ -63,7 +63,7 @@ pullRequestReviews'
6363
:: Maybe Auth
6464
-> Name Owner
6565
-> Name Repo
66-
-> Id PullRequest
66+
-> IssueNumber
6767
-> IO (Either Error (Vector Review))
6868
pullRequestReviews' auth owner repo pr =
6969
executeRequestMaybe auth $ pullRequestReviewsR owner repo pr FetchAll
@@ -73,7 +73,7 @@ pullRequestReviews' auth owner repo pr =
7373
pullRequestReviewR
7474
:: Name Owner
7575
-> Name Repo
76-
-> Id PullRequest
76+
-> IssueNumber
7777
-> Id Review
7878
-> Request k Review
7979
pullRequestReviewR owner repo prid rid =
@@ -95,7 +95,7 @@ pullRequestReviewR owner repo prid rid =
9595
pullRequestReview
9696
:: Name Owner
9797
-> Name Repo
98-
-> Id PullRequest
98+
-> IssueNumber
9999
-> Id Review
100100
-> IO (Either Error Review)
101101
pullRequestReview owner repo prid rid =
@@ -110,7 +110,7 @@ pullRequestReview'
110110
:: Maybe Auth
111111
-> Name Owner
112112
-> Name Repo
113-
-> Id PullRequest
113+
-> IssueNumber
114114
-> Id Review
115115
-> IO (Either Error Review)
116116
pullRequestReview' auth owner repo prid rid =
@@ -121,7 +121,7 @@ pullRequestReview' auth owner repo prid rid =
121121
pullRequestReviewCommentsR
122122
:: Name Owner
123123
-> Name Repo
124-
-> Id PullRequest
124+
-> IssueNumber
125125
-> Id Review
126126
-> Request k [ReviewComment]
127127
pullRequestReviewCommentsR owner repo prid rid =
@@ -144,7 +144,7 @@ pullRequestReviewCommentsR owner repo prid rid =
144144
pullRequestReviewCommentsIO
145145
:: Name Owner
146146
-> Name Repo
147-
-> Id PullRequest
147+
-> IssueNumber
148148
-> Id Review
149149
-> IO (Either Error [ReviewComment])
150150
pullRequestReviewCommentsIO owner repo prid rid =
@@ -158,7 +158,7 @@ pullRequestReviewCommentsIO'
158158
:: Maybe Auth
159159
-> Name Owner
160160
-> Name Repo
161-
-> Id PullRequest
161+
-> IssueNumber
162162
-> Id Review
163163
-> IO (Either Error [ReviewComment])
164164
pullRequestReviewCommentsIO' auth owner repo prid rid =

0 commit comments

Comments
 (0)