Skip to content

fix: Fix label values query when server.http_path_prefix is set #15978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaudum merged 1 commit into from
Jan 29, 2025
Merged

fix: Fix label values query when server.http_path_prefix is set #15978

chaudum merged 1 commit into from
Jan 29, 2025

Conversation

@chaudum
Copy link
Contributor

@chaudum chaudum commented Jan 28, 2025 •
edited
Loading

What this PR does / why we need it:

This commit fixes a bug in the query range round tripper. It fixes the detection of the operation when decoding a HTTP request into a queryrange request object by comparing the path suffix rather than the equality of the full path.

Which issue(s) this PR fixes:
Fixes #15585

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@chaudum
fix: Fix label values query when server.http_path_prefix is set
4ba2ca3 
This commit fixes the detection of the operation based on the provided
path when decoding a HTTP request into a queryrange request object by
comparing the path suffix rather than the equality of the full path.

Signed-off-by: Christian Haudum <[email protected]>
@chaudum chaudum marked this pull request as ready for review January 28, 2025 09:05
@chaudum chaudum requested a review from a team as a code owner January 28, 2025 09:05
@chaudum chaudum merged commit 65f5990 into main Jan 29, 2025
60 checks passed
@chaudum chaudum deleted the chaudum/issue-15585 branch January 29, 2025 06:54
salvacorts pushed a commit that referenced this pull request Feb 12, 2025
@chaudum @salvacorts
fix: Fix label values query when server.http_path_prefix is set (#15978)
0dc531f 
This commit fixes a bug in the query range round tripper. It fixes the detection of the operation when decoding a HTTP request into a queryrange request object by comparing the path suffix rather than the equality of the full path.

Signed-off-by: Christian Haudum <[email protected]>
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 17, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 24, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 5, 2025
Closed
This was referenced Mar 20, 2025
Closed
Closed
This was referenced Mar 31, 2025
Merged
Closed
This was referenced Apr 14, 2025
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 22, 2025
Closed
This was referenced Apr 23, 2025
Merged
Merged
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request May 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M

2 participants

@chaudum @benclive