Skip to content

docs: revise label table code samples #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 6, 2023
Merged

docs: revise label table code samples #1451

merged 8 commits into from
Jan 6, 2023

Conversation

@Mattix23
Copy link
Contributor

@Mattix23 Mattix23 commented Jan 3, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #790 🦕
@Mattix23 Mattix23 requested a review from a team January 3, 2023 19:59
@Mattix23 Mattix23 requested review from a team as code owners January 3, 2023 19:59
@Mattix23 Mattix23 requested review from atulep and tswast January 3, 2023 19:59
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 3, 2023
@snippet-bot
Copy link

snippet-bot bot commented Jan 3, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jan 3, 2023
@tswast tswast enabled auto-merge (squash) January 3, 2023 20:47
parthea
parthea reviewed Jan 4, 2023
View reviewed changes
samples/snippets/label_table.py
table_id = "your-project.your_dataset.your_table_name"

# [END bigquery_label_table]
table_id = orig_table_id
Copy link
Contributor

@parthea parthea Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify the reason that orig_table_id is needed? Could we remove orig_table_id and just have table_id?
@tswast tswast merged commit 14ae1f2 into main Jan 6, 2023
@tswast tswast deleted the issue790-label_table branch January 6, 2023 18:42
@release-please release-please bot mentioned this pull request Jan 6, 2023
Merged
This was referenced Jan 24, 2023
Closed
Closed
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@Mattix23 @gcf-owl-bot
@tswast @abdelmegahedgoogle
docs: revise label table code samples (googleapis#1451)
8462757 
* docs: revise label table code samples

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* added TODO to clean up snippets.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Tim Swast <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium.

4 participants

@Mattix23 @tswast @parthea