Skip to content

fix: Improve Series.replace for dict input #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 26, 2024
Merged

fix: Improve Series.replace for dict input #907

merged 4 commits into from
Aug 26, 2024

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented Aug 20, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 359980361 🦕
@shobsi shobsi requested review from a team as code owners August 20, 2024 04:58
@shobsi shobsi requested a review from mattyopl August 20, 2024 04:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 20, 2024
@shobsi shobsi requested a review from TrevorBergeron August 20, 2024 17:52
@shobsi shobsi merged commit 4208044 into main Aug 26, 2024
@shobsi shobsi deleted the shobs-series-replace-empty-dict branch August 26, 2024 16:45
@release-please release-please bot mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

3 participants

@shobsi @TrevorBergeron