Skip to content

fix: Properly identify non-unique index in non-pk tables #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 17, 2024
Merged

fix: Properly identify non-unique index in non-pk tables #699

merged 6 commits into from
May 17, 2024

Conversation

@TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented May 17, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@TrevorBergeron TrevorBergeron requested review from a team as code owners May 17, 2024 00:05
@TrevorBergeron TrevorBergeron requested a review from GarrettWu May 17, 2024 00:05
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 17, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 17, 2024
@TrevorBergeron TrevorBergeron requested a review from tswast May 17, 2024 00:28
tswast
tswast reviewed May 17, 2024
View reviewed changes
bigframes/session/_io/bigquery/read_gbq_table.py
index_cols: List[str],
api_name: str,
) -> bool:
if len(index_cols) == 0:
Copy link
Collaborator

@tswast tswast May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some unit tests specificaly for this method with index_cols = [] and primary_keys = []; index_cols = ['some_col']
Copy link
Contributor Author

@TrevorBergeron TrevorBergeron May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some unit tests
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 17, 2024
@TrevorBergeron TrevorBergeron requested a review from tswast May 17, 2024 16:27
tswast
tswast approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@tswast tswast enabled auto-merge (squash) May 17, 2024 17:24
@tswast tswast merged commit 6e0f4d8 into main May 17, 2024
@tswast tswast deleted the uniqueness_fix branch May 17, 2024 18:01
@release-please release-please bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

3 participants

@TrevorBergeron @tswast