Skip to content

feat: support gcf vpc connector in remote_function #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2024
Merged

feat: support gcf vpc connector in remote_function #677

merged 3 commits into from
May 10, 2024

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented May 10, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 337077316 🦕
@shobsi shobsi requested review from a team as code owners May 10, 2024 00:35
@shobsi shobsi requested a review from ashleyxuu May 10, 2024 00:35
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 10, 2024
@shobsi shobsi mentioned this pull request May 10, 2024
Closed
4 tasks
@shobsi shobsi requested a review from GarrettWu May 10, 2024 00:36
@shobsi shobsi merged commit 9ca92d0 into main May 10, 2024
@shobsi shobsi deleted the shobs-gcf-vpc-con branch May 10, 2024 23:54
@release-please release-please bot mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

4 participants

@shobsi @ashleyxuu @jiaxunwu