Skip to content

fix: address more technical writers feedback #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: address more technical writers feedback #581

merged 1 commit into from
Apr 5, 2024

Conversation

@ashleyxuu
Copy link
Contributor

@ashleyxuu ashleyxuu commented Apr 5, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@ashleyxuu ashleyxuu requested review from a team as code owners April 5, 2024 17:33
@ashleyxuu ashleyxuu requested a review from junyazhang April 5, 2024 17:33
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 5, 2024
@junyazhang junyazhang merged commit 4b08d92 into main Apr 5, 2024
@junyazhang junyazhang deleted the ashleyxu-address-more-fb branch April 5, 2024 23:19
@release-please release-please bot mentioned this pull request Apr 5, 2024
Merged
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
@ashleyxuu @Genesis929
fix: address more technical writers feedback (#581)
808e472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

3 participants

@ashleyxuu @junyazhang