Skip to content

feat: Add ml.metrics.pairwise.paired_manhattan_distance #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

feat: Add ml.metrics.pairwise.paired_manhattan_distance #392

merged 1 commit into from
Feb 27, 2024

Conversation

@ashleyxuu
Copy link
Contributor

@ashleyxuu ashleyxuu commented Feb 26, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #325978655 🦕
@ashleyxuu ashleyxuu requested a review from GarrettWu February 26, 2024 20:00
@ashleyxuu ashleyxuu requested review from a team as code owners February 26, 2024 20:00
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 26, 2024
@ashleyxuu ashleyxuu force-pushed the ashleyxu-manhattan-distance branch from b23f7fa to 8812be9 Compare February 26, 2024 21:56
GarrettWu
GarrettWu approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@GarrettWu GarrettWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz update the commit title as well.
@ashleyxuu ashleyxuu merged commit 9d31865 into main Feb 27, 2024
@ashleyxuu ashleyxuu deleted the ashleyxu-manhattan-distance branch February 27, 2024 15:30
@release-please release-please bot mentioned this pull request Feb 26, 2024
Merged
@ashleyxuu ashleyxuu changed the title feat: Add ml.metrics.pairwise.manhattan_distance feat: Add ml.metrics.pairwise.paired_manhattan_distance Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

3 participants

@ashleyxuu @GarrettWu