Skip to content

deps: move bigtable and pubsub to extras #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

deps: move bigtable and pubsub to extras #1696

merged 3 commits into from
May 8, 2025

Conversation

@GarrettWu
Copy link
Contributor

@GarrettWu GarrettWu commented May 6, 2025 •
edited
Loading

b/414417052

Split the test file to skip separately.
@GarrettWu GarrettWu requested review from shuoweil and tswast May 6, 2025 19:10
@GarrettWu GarrettWu self-assigned this May 6, 2025
@GarrettWu GarrettWu requested review from a team as code owners May 6, 2025 19:10
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 6, 2025
@tswast
Copy link
Collaborator

tswast commented May 6, 2025

With the dependency missing from type checking, we're getting some failures:

nox > mypy bigframes tests/system tests/unit --check-untyped-defs --explicit-package-bases '--exclude="^third_party"'
tests/system/large/streaming/test_pubsub.py:24: error: Module "google.cloud" has no attribute "pubsub"  [attr-defined]
Found 1 error in 1 file (checked 380 source files)
nox > Command mypy bigframes tests/system tests/unit --check-untyped-defs --explicit-package-bases '--exclude="^third_party"' failed with exit code 1
nox > Session mypy failed.
Error: Process completed with e
@GarrettWu
Copy link
Contributor Author

GarrettWu commented May 6, 2025

With the dependency missing from type checking, we're getting some failures:

nox > mypy bigframes tests/system tests/unit --check-untyped-defs --explicit-package-bases '--exclude="^third_party"'
tests/system/large/streaming/test_pubsub.py:24: error: Module "google.cloud" has no attribute "pubsub"  [attr-defined]
Found 1 error in 1 file (checked 380 source files)
nox > Command mypy bigframes tests/system tests/unit --check-untyped-defs --explicit-package-bases '--exclude="^third_party"' failed with exit code 1
nox > Session mypy failed.
Error: Process completed with e

pubsub doesn't link the module. The ignore label was missed when moving the imports. Added back.
tswast
tswast approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@tswast tswast merged commit 597d817 into main May 8, 2025
23 of 24 checks passed
@tswast tswast deleted the garrettwu-streaming-dep branch May 8, 2025 15:52
@release-please release-please bot mentioned this pull request May 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

3 participants

@GarrettWu @tswast